enable use_information_schema for ATTACH (1.5)#495
Merged
Conversation
This is a backport of the PR duckdb#493 to `v1.5-variegata` stable branch. PR following the conversation started at duckdb#490 I have excluded from the PR handling enums, composite types and indexes that are unfortunately reported differently by different DB vendors. I see a couple options here: - leave ignored for now - try to auto-detect the actual DB this is talking to and pick the right queries to get the right info this way - change from a `use_info_schema param` to a `pg_compatibility_mode_for=(spanner|redshift|cockroach|...)` Open to any of those options. Though auto-detection is probably the most brittle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of the PR #493 to
v1.5-variegatastable branch.PR following the conversation started at #490
I have excluded from the PR handling enums, composite types and indexes that are unfortunately reported differently by different DB vendors.
I see a couple options here:
use_info_schema paramto apg_compatibility_mode_for=(spanner|redshift|cockroach|...)Open to any of those options. Though auto-detection is probably the most brittle.