Skip to content

Conversation

@CrisBarreiro
Copy link
Contributor

@CrisBarreiro CrisBarreiro commented Nov 25, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212075417798701?focus=true

Description

Migrate downloads to DatabaseProvider as part of an initiative to increase performance

Steps to test this PR

Feature 1

  • Smoke test downloads

UI changes

n/a


Note

Replace direct Room builder with DatabaseProvider-backed Room database and add :data-store-api dependency.

  • Downloads DB initialization:
    • Replace Room.databaseBuilder with DatabaseProvider.buildRoomDatabase in DownloadsModule using RoomDatabaseConfig(fallbackToDestructiveMigration = true).
    • Update DI to provide DownloadsDatabase via DatabaseProvider (remove Context usage).
  • Dependencies:
    • Add implementation project(path: ':data-store-api') in downloads/downloads-impl/build.gradle.

Written by Cursor Bugbot for commit e3e87fb. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

CrisBarreiro commented Nov 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CrisBarreiro CrisBarreiro changed the base branch from feature/cris/create-database-provider to graphite-base/7205 November 26, 2025 10:57
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/database-provider-migrate-downloads branch from 77e0ff8 to 11011a7 Compare November 27, 2025 10:03
@CrisBarreiro CrisBarreiro changed the base branch from graphite-base/7205 to feature/cris/create-database-provider November 27, 2025 10:04
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/database-provider-migrate-downloads branch 4 times, most recently from 5ed4dcd to 94733d8 Compare November 27, 2025 15:05
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/create-database-provider branch from 6c57698 to 8add7fc Compare November 27, 2025 15:05
Base automatically changed from feature/cris/create-database-provider to develop December 1, 2025 16:01
@CrisBarreiro CrisBarreiro force-pushed the feature/cris/database-provider-migrate-downloads branch from 94733d8 to e3e87fb Compare December 17, 2025 16:46
@CrisBarreiro CrisBarreiro marked this pull request as ready for review December 17, 2025 16:48
@CrisBarreiro CrisBarreiro requested a review from anikiki December 17, 2025 16:49
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉
Smoke tested downloads (fresh install and app update) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants