Skip to content

Conversation

@catalinradoiu
Copy link
Contributor

@catalinradoiu catalinradoiu commented Dec 9, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1212350440774862?focus=true

Description

Added a new navigation test to verify that the app correctly handles duck:// schema links to the search engine results page (SERP) with a search query. The test ensures that when a user clicks a duck:// link with a search query parameter, the app properly opens and displays the search query in the omnibar.

This test was added as a separate step in the End-to-End tests (Robin) workflow.

Steps to test this PR

Deeplink Functionality

  • Run the deeplink_to_serp_with_query.yaml test both locally and on the maestro cloud

Test run: https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/flow/run_01kc1jpy6ve1m9ykcg2whrnbzb

UI changes

No UI changes, only additional test coverage.


Note

Adds a Maestro flow to validate duck:// SERP query handling and runs it in the end-to-end Robin workflow via the navigationTest tag.

  • Tests:
    • Add .maestro/deeplink/deeplink_to_serp_with_query.yaml to validate duck:// SERP link opens with the query shown in omnibarTextInput (with retries, clean launch, and onboarding skipped).
  • CI:
    • Update .github/workflows/end-to-end-robintest.yml to include a new "Deeplink tests" Maestro Cloud step running include-tags: navigationTest.

Written by Cursor Bugbot for commit 35bce88. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

@catalinradoiu catalinradoiu marked this pull request as ready for review December 11, 2025 10:22
@anikiki anikiki self-requested a review December 11, 2025 10:41
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@catalinradoiu catalinradoiu changed the title Create new deeplink test for SERP with search query and add it as a new step end-to-end-robintest workflow Create new navigation test for SERP with search query and add it as a new step end-to-end-robintest workflow Dec 11, 2025
@catalinradoiu catalinradoiu merged commit 8fb21be into develop Dec 11, 2025
15 checks passed
@catalinradoiu catalinradoiu deleted the feature/cradoiu/serp-deeplink-maestro-test branch December 11, 2025 12:03
cursor bot pushed a commit that referenced this pull request Dec 19, 2025
… new step end-to-end-robintest workflow (#7322)

Task/Issue URL:
https://app.asana.com/1/137249556945/project/1211724162604201/task/1212350440774862?focus=true

### Description
Added a new navigation test to verify that the app correctly handles
duck:// schema links to the search engine results page (SERP) with a
search query. The test ensures that when a user clicks a `duck://` link
with a search query parameter, the app properly opens and displays the
search query in the omnibar.

This test was added as a separate step in the End-to-End tests (Robin)
workflow.

### Steps to test this PR

_Deeplink Functionality_
- [x] Run the deeplink_to_serp_with_query.yaml test both locally and on
the maestro cloud

Test run:
https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/flow/run_01kc1jpy6ve1m9ykcg2whrnbzb

### UI changes
No UI changes, only additional test coverage.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Adds a Maestro flow to validate duck:// SERP query handling and runs
it in the end-to-end Robin workflow via the navigationTest tag.
> 
> - **Tests**:
> - Add `.maestro/deeplink/deeplink_to_serp_with_query.yaml` to validate
`duck://` SERP link opens with the query shown in `omnibarTextInput`
(with retries, clean launch, and onboarding skipped).
> - **CI**:
> - Update `.github/workflows/end-to-end-robintest.yml` to include a new
"Deeplink tests" Maestro Cloud step running `include-tags:
navigationTest`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
35bce88. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants