Remove index param in autocomplete click phrase and website pixels #7331
+1
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikiki
approved these changes
Dec 11, 2025
Contributor
anikiki
left a comment
anikiki
left a comment
There was a problem hiding this comment.
Looks good and works as expected! 🎉
cursor bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
…7331) Task/Issue URL: https://app.asana.com/1/137249556945/project/1212015278241917/task/1212373029583380?focus=true ### Description We want to remove index parameter in the existing pixels `m_autocomplete_click_phrase` and `m_autocomplete_click_website` Revert commit 4fdeb94 that introduce this specific parameter. ### Steps to test this PR - [x] Open the app, focus on the omnibar and type in a query. - [x] Verify that clicking on a search suggestion sends an `m_autocomplete_click_phrase` pixel without `search_suggestion_index` parameter. - [x] Verify that clicking on a website search suggestion sends an `m_autocomplete_click_website` pixel without `search_suggestion_index` parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1212015278241917/task/1212373029583380?focus=true
Description
We want to remove index parameter in the existing pixels
m_autocomplete_click_phraseandm_autocomplete_click_websiteRevert commit 4fdeb94 that introduce this specific parameter.
Steps to test this PR
m_autocomplete_click_phrasepixel withoutsearch_suggestion_indexparameter.m_autocomplete_click_websitepixel withoutsearch_suggestion_indexparameter.Note
Removes the search_suggestion_index parameter from autocomplete click phrase/website pixels and deletes related code/tests.
search_suggestion_indexfromfireAutocompletePixelforAUTOCOMPLETE_SEARCH_PHRASE_SELECTIONandAUTOCOMPLETE_SEARCH_WEBSITE_SELECTION.AutocompletePixelParamsand all usages.mapOffor pixel params.search_suggestion_indexpresence and index calculations in autocomplete search suggestion clicks.Written by Cursor Bugbot for commit 33c00d8. This will update automatically on new commits. Configure here.