Add support for IMAP chunks#54
Merged
Merged
Conversation
Member
|
This is great! Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the MagicaVoxel editor, the order in which palette entries appear doesn't actually correspond to the palette index stored per-voxel. Instead, there is an "index map" indirection table, as described here. When using this crate, I would like to be able to discern the user-displayed index for each palette entry, so I need to be able to read this data. This didn't look like it was already supported, so I have added the ability to read the index map.
For reference, here's another
.voxreader implementation that uses the index map to reorder the palette.