Resolve docs/followups: scaffold validation, targeted upstream fixes, connect, View/Map writers, bulk labels

[dynamics365ninja]

Works through docs/followups, resolving everything in it except three items that are whole subsystems rather than fixes (listed at the bottom). Resolved entries are removed from the follow-up docs as they land; the two docs now list open work and nothing else.

Rebased on current main, so #112 (modify method), #113 (journal/undo) and the #114 HTTP transport are already accounted for rather than duplicated. Two things were found to be partly done and were not rebuilt: the MCP labels tool already had bulk create (only the CLI side was missing), and the modify command family now exists (only the wider write surface is left).

Scaffold validation — issue #70 follow-ups

• ScaffoldFileWriter.EnsureValueShapes runs from both Write overloads: requires the XMLSchema-instance declaration on the roots whose fields are polymorphic (AxEnum, AxTable, AxView, AxMap, AxEdt*), and rejects anything outside true/false/1/0 in CLR-bool elements (IsExtensible) — exactly what XmlConvert.ToBoolean accepts, so both the NoYes spelling and garbage are caught. Deliberately not a blanket rule: AxClass/AxMenuItem/AxQuery are written without the declaration today and read back fine.
• --verify on GenerateSettings reads an artefact back through the Metadata API after writing. Skipped (never fails) when the runtime is absent, so offline generation keeps working; only --install-to is verifiable, because the provider resolves objects by name inside the packages paths and an arbitrary --out path would either be missed or matched against a different same-named object.

Targeted upstream fixes

Fix	Change
Label where-used	ResolveTargetPaths recognises @WAX2194, @LabelFile:LabelId, /Labels/@… and emits the exact /Labels/@<ref> path instead of a bare name matching nothing
[ExtensionOf] casing	ExtensionOfRx gains IgnoreCase — X++ casing varies freely on the Str intrinsic, so class extensions were silently missed by CoC indexing
Search ranking	All 16 object-level Search* methods order by m.IsCustom DESC first, so custom/ISV objects are neither buried nor truncated away by LIMIT
generate table	New --configuration-key / --form-ref; omitted when unset so AOT defaults still apply
Inherited members	GetClassDetails walks the ExtendsName chain (recursive CTE, bounded at 32 hops) and reports inherited methods in a separate list, each stamped with its DeclaringClass
OLS coverage	GetSecurityCoverage reports row-level (XDS) state explicitly: Constrained / NotConstrained / Unknown / NotApplicable

The OLS item was flagged "verify, do not assume" — it turned out to be a stronger gap than upstream's. The CLI indexes XDS policies (SecurityPolicies.ConstrainedTable) but GetSecurityCoverage never read them, so get security --type Table X returned a roles-only answer that reads as "no row-level security" when the CLI simply never looked. Unknown covers the case where the index holds no policies at all, so zero matches is never mistaken for an assurance.

New features from the deferred list

• d365fo connect <url> — probes GET /health first, so a mistyped URL reports SERVER_UNREACHABLE instead of producing a config that yields no tools (indistinguishable from inside an editor). Echoes the resolved MCP_SERVER_MODE back, warning when it is not full. Only the named entry is written: other servers and top-level keys survive, JSONC is tolerated, an unparseable config is refused rather than overwritten, and replacing an entry needs --force.
• generate view / generate map — ViewScaffolder and MapScaffolder. Honesty constraints upstream had to retrofit are built in: no <Ranges> and no invented <Title*> on views, a computed field without an explicit type is rejected rather than guessed, and a mapping connecting a field the map does not declare is rejected rather than compiled into something that silently never matches.
• label create --entry KEY=VALUE — per-key error isolation mirroring the MCP handler's payload. Partial success stays ok:true (the writes that landed are real and journaled; gate on data.failed == 0); BATCH_FAILED when nothing could be written. The positional form keeps its exact previous behaviour, including the hard KEY_EXISTS scripts rely on.

Grounded against a real AOT, not guessed

View and Map shapes were verified against shipped standard-model files on the local AOS (196 models) rather than inferred. That settled two things a reasonable guess gets wrong: bound view fields are always AxViewFieldBound with no primitive suffix (21 846 occurrences, no exceptions) while only computed fields carry a type; and map fields use the same suffix vocabulary as AxTableField, so both now share XppScaffolder.ConcreteFieldSuffix and cannot disagree on one EDT.

A round-trip through the CLI's own index surfaced a real pre-existing bug. ParseView searched Descendants() for <Fields> and matched the empty one nested in the first <AxTableFieldGroup>, which the AOT emits before the view's real <Fields>. Every shipped view therefore indexed with zero fields. Fixed to read direct children like every other parser here — the same fix already applied table-side.

Verification

647 tests pass in Release (262 CLI + 385 Core), 60 of them new. Beyond unit tests: connect was exercised against a live d365fo-mcp --http instance including both failure paths, and generate view/generate map were driven end to end through index extract → get view / find usages. The [ExtensionOf] regression test was confirmed to fail without its fix.

Two gaps worth knowing: the label where-used fix has no unit test — D365FO.Bridge targets net48 and no test project references it, so it is build-verified only; and get map still has no CLI command (the repository method exists), which is a separate read-surface gap I did not widen into.

Still open

Three items remain across both docs, all multi-day subsystems rather than fixes: the rest of the modify surface (add-field, add-control, modify-property, extension writers), the knowledge-base subsystem, and the TRUDUtils generators / form auto-repair.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FfAAnxQDnPHRB1ne5H724n