docs: correct architecture-diagram drift against current source - #135
Merged
Conversation
docs/ARCHITECTURE.md and docs/img/solution-architecture-diagram.svg were last touched 2026-06-12/15; since then HTTP transport, the modification journal/undo, d365fo connect, and the Copilot/Claude skill bundle all landed without the diagram or ARCHITECTURE.md being updated. Verified every quantitative claim against source and corrected what had drifted: - MCP tool count disagreed three ways across docs (20/22/26) against the actual 24 Descriptor entries in ToolCatalog.cs. - The bridge box in the SVG claimed "all generate writes"; most scaffolders write XML directly, the bridge is only used with --install-to. - FormPatternCatalog counts (18/19) were stale against the actual 20 top-level patterns / 16 sub-patterns. - Lint rule table listed two rules that don't exist in code (runbase-no-can-go-batch, unknown-label-ref) instead of the real batch-no-cango / public-instance-field. - Added HTTP transport, modification journal/undo, and d365fo connect as new ARCHITECTURE.md sections — previously undocumented there even though CAPABILITIES.md/README already covered them. - Corrected the followups doc's claim that the CLI "ships as a .NET global tool via NuGet" — no PackAsTool/tool packaging exists; it's git-clone-and-build today. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/ARCHITECTURE.mdanddocs/img/solution-architecture-diagram.svgwere last touched 2026-06-12/15. Since then HTTP transport (#114), the modification journal +d365fo undo(#113),d365fo modify methodvia the bridge (#112),d365fo connect <url>, and the Copilot/Claude skill bundle (#127) all landed without the diagram orARCHITECTURE.mdbeing updated to mention them.Triggered by noticing upstream
d365fo-mcp-serverdid the identical self-audit on itself on 2026-08-04 (PR #811, "the bridge is not the sole write path") — same category of drift, just further along here.Corrections (each verified against source, not against the previous docs)
new Descriptor(count insrc/D365FO.Mcp/ToolCatalog.cs--install-toFormPatternCatalog.csrunbase-no-can-go-batch,unknown-label-ref(don't exist in code)batch-no-cango,public-instance-fieldLintCommand.csgeneratecommand count (SVG)Program.csregistrations, incl.simple-listaliasPackAsTool/packaging configured)Also
Added three short
ARCHITECTURE.mdsections that were previously undocumented there (despite already being covered inCAPABILITIES.md/README.md): HTTP transport, Modification journal & undo, Editor connect (d365fo connect).Known gap
The SVG's "Command Groups" panel has no room left to add
modify/undo/journallabels without resizing the panel — flagged as a follow-up rather than force-cramming text.Verification
7c0fef6) as the existingdocs/followups/upstream-port-2026-08.mdboundary — no new upstream commits to fold in.<text>contents.🤖 Generated with Claude Code