Repository navigation
test: make THIRD_PARTY_NOTICES snapshot platform-stable - #29
Merged
Merged
Conversation
The generated NOTICES file lists bundled dependencies in module-resolution order, which varies by platform/filesystem, so snapshotting it raw failed across the CI OS matrix even when the bundled package set was identical. The committed snapshot was also stale after a chrome-devtools-frontend bump. Normalize before snapshotting: strip version numbers (already done), split on the DEPENDENCY DIVIDER into per-package entries, sort them, and rejoin. The set of bundled packages contains no platform-specific/binary deps, so the sorted, version-masked form is identical regardless of emission order. Snapshot regenerated accordingly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining red CI check (
Compile and run tests→tests/third_party_notices.test.ts).Why it was failing
The generated
THIRD_PARTY_NOTICESlists bundled deps in module-resolution order (platform/filesystem-dependent), so the raw snapshot failed across the OS matrix. The committed snapshot was also stale after achrome-devtools-frontendbump.Fix
Normalize before snapshotting: strip versions, split on
DEPENDENCY DIVIDER, sort entries, rejoin. Verified the bundled set contains no platform-specific/binary packages, so the sorted, version-masked form is platform-independent. Snapshot regenerated.Validated locally (passes); relying on CI matrix to confirm cross-platform.
🤖 Generated with Claude Code