Skip to content

fix build-test when staged npm package release workflow is missing #27

Closed

Description

@dzianisv

Summary

PR CI build-test is failing in scripts/stage_npm_packages.py because it assumes a rust-release workflow exists for CODEX_VERSION=0.74.0, but no such workflow can be found.

Repro

Seen on PR #25 on 2026-03-16:

  • Workflow/job: build-test
  • Run: 23166074029
  • Job: 67306274850

Relevant failure:

  • RuntimeError: Unable to find rust-release workflow for version 0.74.0.

Stack excerpt:

  • scripts/stage_npm_packages.py:101 raises in resolve_release_workflow(version)
  • called from resolve_workflow_url()
  • called from main() during npm package staging

Why this matters

This blocks PR validation even when code changes are unrelated to npm packaging. The workflow should either:

  • derive a valid releasable version dynamically,
  • fall back more gracefully when a release workflow is not present, or
  • avoid requiring release artifacts for ordinary PR validation.

Acceptance criteria

  • build-test passes on PRs without requiring a missing release workflow
  • scripts/stage_npm_packages.py handles absent release workflows deterministically and with a clearer policy

Activity

  1. dzianisv commented on Mar 17, 2026

    @dzianisv
    OwnerAuthor

    Implemented and pushed on branch . PR is up: #31.

    What changed:

    • now queries release workflows explicitly instead of the fork-local Actions history.
    • the missing-workflow error now includes the repo, branch, and workflow path that were queried.
    • added to lock in the upstream repo-qualified lookup behavior.

    Validation:

    • direct upstream lookup for now resolves
    • end-to-end staging run succeeded after reproducing CI's prerequisite locally and produced the expected tarballs
  2. dzianisv commented on Mar 17, 2026

    @dzianisv
    OwnerAuthor

    Implemented and pushed on branch issue-27-build-test-release-workflow. PR is up: #31.

    What changed:

    • scripts/stage_npm_packages.py now queries openai/codex release workflows explicitly instead of the fork-local Actions history.
    • the missing-workflow error now includes the repo, branch, and workflow path that were queried.
    • added scripts/test_stage_npm_packages.py to lock in the upstream repo-qualified lookup behavior.

    Validation:

    • python3 -m unittest scripts/test_stage_npm_packages.py
    • direct upstream lookup for 0.74.0 now resolves https://github.com/openai/codex/actions/runs/20345806534
    • end-to-end staging run succeeded after reproducing CI's dotslash prerequisite locally and produced the expected codex-npm-*.tgz tarballs
  3. dzianisv commented on Mar 17, 2026

    @dzianisv
    OwnerAuthor

    Follow-up fix pushed to PR #31.

    After the rust-release lookup fix landed, build-test exposed a separate deterministic formatting failure:

    • docs/reflection.md was not Prettier-clean
    • codex-rs/core/src/tools/js_repl/kernel.js needed formatting
    • the vendored minified bundle codex-rs/core/src/tools/js_repl/meriyah.umd.min.js should be ignored rather than reformatted

    Pushed commit:

    • 892614c61 style: fix build-test prettier failures

    Validation:

    • pnpm dlx prettier@3.5.3 --check *.json *.md docs/*.md .github/workflows/*.yml **/*.js

    PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions