Repository navigation
Conversation
Owner
Author
|
CI status after opening this PR:
What the failing checks are showing right now:
I updated issue
Next follow-on work is still |
Owner
Author
|
Superseded by #35, which now carries this branch's changes on the consolidated integration branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stdio_server_bin()buildcodex-rmcp-client'stest_stdio_serveron demand under Cargo so fresh worktrees can run the RMCP-backed core suitesRoot Cause
TestCodexBuilderwas routing every config with amodel_catalogthroughThreadManager::new(...), which made the default injected test catalog authoritative and disabled remote/modelsrefresh.coreintegration tests that depend ontest_stdio_serverassumed the cross-package binary was already built, which is false in a fresh worktree running onlycodex-coretests.Testing
cargo test -p core_test_support --lib -- --nocapturecargo test -p codex-core --test all suite::remote_models::remote_models_truncation_policy_with_tool_output_override -- --nocapture --exactcargo test -p codex-core --test all suite::search_tool::search_tool_selection_persists_across_turns -- --nocapture --exactcargo test -p codex-core --test all suite::truncation::mcp_tool_call_output_exceeds_limit_truncated_for_model -- --nocapture --exactcargo test -p codex-core --test all suite::rmcp_client::stdio_server_round_trip -- --nocapture --exactcargo test -p codex-core --test all suite::sqlite_state::mcp_call_marks_thread_memory_mode_polluted_when_configured -- --nocapture --exactcargo test -p codex-core --test all suite::search_tool:: -- --nocapturecargo test -p codex-core --test all suite::rmcp_client:: -- --nocaptureFixes #26