Repository navigation
Conversation
added 2 commits
March 18, 2026 10:01
Apply cross-provider /model selections to the live TUI session instead of forcing a fresh session before the change takes effect. Update the app and chat widget runtime config immediately, keep the persisted config change, and align the TUI regression tests with the intended in-session behavior. Also fix the GitHub Copilot chat/completions fallback path for Claude-family models. Instead of collapsing fallback replies into a single assistant text message, detect Claude-style <tool_call>/<tool_result> wrapper blocks and synthesize native ResponseItem::FunctionCall and ResponseItem::FunctionCallOutput items so Codex handles them like first-class tool activity. Preserve surrounding assistant prose as normal assistant messages and add focused client-side regression tests for wrapper conversion and plain-text passthrough. This replaces the UI-only workaround direction with provider-boundary normalization, which is the correct place to adapt non-Responses payloads into Codex's native item model.
|
Carried forward onto I pushed a fresh consolidation branch from Validated on
Recommendation: merge from |
Owner
Author
|
Superseded by #38, which now carries the consolidated branch with the rebased model-switching fixes plus the CI npm-staging fix. Please do not merge this branch separately. |
Owner
Author
|
Superseded by #38, which now carries the consolidated |
Owner
Author
|
Superseded by direct landing on main at 1328bae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
Summary
azure/gpt-5.4-pro/model/modelflowValidation
cd codex-rs && cargo test -p codex-core models_dev_provider_alias_model_inherits_canonical_reasoning_metadatacd codex-rs && CARGO_INCREMENTAL=0 cargo test -p codex-tui --test all models_dev_provider_alias_model_switch_then_prompt_uses_selected_reasoning_effort -- --nocaptureNotes
/models/models.devalias path by reusing bundled canonical metadataazure/gpt-5.4-pro)