Skip to content

fix: 관리자 URL 매칭을 PathPatternRequestMatcher로 전환 #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jei007 merged 1 commit into from
Oct 30, 2026
Merged

fix: 관리자 URL 매칭을 PathPatternRequestMatcher로 전환 #1396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/main/java/egovframework/com/cmm/interceptor/AuthenticInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import java.util.Collections;
import java.util.List;

import org.springframework.security.web.util.matcher.AntPathRequestMatcher;
import org.springframework.security.web.servlet.util.matcher.PathPatternRequestMatcher;
import org.springframework.web.servlet.HandlerInterceptor;
import org.springframework.web.servlet.ModelAndView;
import org.springframework.web.servlet.ModelAndViewDefiningException;
Expand All @@ -28,6 +28,7 @@
* 2011.09.07 서준식 인증이 필요없는 URL을 패스하는 로직 추가
* 2017.08.31 장동한 인증된 사용자 체크로직 변경 및 관리자 권한 체크 로직 추가
* 2021.08.27 신용호 dummy모드 사용시 "60. 권한관리" 접근오류 수정
* 2026.10.27 Spring Security 6.5 권장 PathPatternRequestMatcher로 전환
* </pre>
*/

Expand All @@ -37,12 +38,17 @@ public class AuthenticInterceptor implements HandlerInterceptor {
/** 관리자 접근 권한 패턴 목록 */
private List<String> adminAuthPatternList;

/** 설정 시 파싱한 관리자 접근 권한 패턴 */
private List<PathPatternRequestMatcher> adminAuthPatternMatchers;

public List<String> getAdminAuthPatternList() {
return adminAuthPatternList;
}

public void setAdminAuthPatternList(List<String> adminAuthPatternList) {
this.adminAuthPatternList = Collections.unmodifiableList(adminAuthPatternList);
PathPatternRequestMatcher.Builder matcherBuilder = PathPatternRequestMatcher.withDefaults();
this.adminAuthPatternMatchers = adminAuthPatternList.stream().map(matcherBuilder::matcher).toList();
}

/**
Expand All @@ -63,13 +69,11 @@ public boolean preHandle(HttpServletRequest request, HttpServletResponse respons
List<String> authList = EgovUserDetailsHelper.getAuthorities();
//관리자인증여부
boolean adminAuthUrlPatternMatcher = false;
//AntPathRequestMatcher
AntPathRequestMatcher antPathRequestMatcher = null;
//관리자가 아닐때 체크함
for(String adminAuthPattern : adminAuthPatternList){
antPathRequestMatcher = new AntPathRequestMatcher(adminAuthPattern);
if(antPathRequestMatcher.matches(request)){
//관리자 URL 패턴 체크
for(PathPatternRequestMatcher adminAuthPatternMatcher : adminAuthPatternMatchers){
if(adminAuthPatternMatcher.matches(request)){
adminAuthUrlPatternMatcher = true;
break;
}
}
//관리자 권한 체크
Expand Down
148 changes: 148 additions & 0 deletions src/test/java/egovframework/com/cmm/interceptor/AuthenticInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,148 @@
package egovframework.com.cmm.interceptor;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.lang.reflect.Proxy;
import java.util.HashMap;
import java.util.List;
import java.util.Map;

import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;
import org.springframework.web.servlet.ModelAndViewDefiningException;
import org.springframework.web.util.ServletRequestPathUtils;

import egovframework.com.cmm.service.EgovUserDetailsService;
import egovframework.com.cmm.util.EgovUserDetailsHelper;
import jakarta.servlet.http.HttpServletMapping;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.MappingMatch;

/** DB나 Spring 컨텍스트 없이 관리자 URL 매칭과 권한별 리다이렉트를 검증한다. */
class AuthenticInterceptorTest {

private EgovUserDetailsService previousUserDetailsService;

@BeforeEach
void saveUserDetailsService() {
previousUserDetailsService = new EgovUserDetailsHelper().getEgovUserDetailsService();
}

@AfterEach
void restoreUserDetailsService() {
new EgovUserDetailsHelper().setEgovUserDetailsService(previousUserDetailsService);
}

@ParameterizedTest(name = "{0}, role={1}, authenticated={2}")
@CsvSource(nullValues = "ALLOW", value = {
"/sec/ram/EgovAuthorList.do, ROLE_USER, true, redirect:/uat/uia/egovLoginUsr.do?auth_error=1",
"/sec/ram/EgovAuthorList.do, ROLE_ADMIN, true, ALLOW",
"/sec/ram/.do, ROLE_USER, true, redirect:/uat/uia/egovLoginUsr.do?auth_error=1",
"/sec/ram/.do, ROLE_ADMIN, true, ALLOW",
"/cop/bbs/SelectBBSMasterInfs.do, ROLE_USER, true, ALLOW",
"/cop/bbs/SelectBBSMasterInfs.do, ROLE_ADMIN, true, ALLOW",
"/sec/ram/nested/EgovAuthorList.do, ROLE_USER, true, ALLOW",
"/sec/ram/nested/EgovAuthorList.do, ROLE_ADMIN, true, ALLOW",
"/SEC/ram/EgovAuthorList.do, ROLE_USER, true, ALLOW",
"/SEC/ram/EgovAuthorList.do, ROLE_ADMIN, true, ALLOW",
"/sec/ram/EgovAuthorList.do/, ROLE_USER, true, ALLOW",
"/sec/ram/EgovAuthorList.do/, ROLE_ADMIN, true, ALLOW",
"/sec/ram/EgovAuthorList.do.json, ROLE_USER, true, ALLOW",
"/sec/ram/EgovAuthorList.do.json, ROLE_ADMIN, true, ALLOW",
"/sec/ram/EgovAuthorList.do, ROLE_USER, false, redirect:/uat/uia/egovLoginUsr.do",
"/sec/ram/EgovAuthorList.do, ROLE_ADMIN, false, redirect:/uat/uia/egovLoginUsr.do",
"/cop/bbs/SelectBBSMasterInfs.do, ROLE_USER, false, redirect:/uat/uia/egovLoginUsr.do",
"/cop/bbs/SelectBBSMasterInfs.do, ROLE_ADMIN, false, redirect:/uat/uia/egovLoginUsr.do"
})
void urlAuthorizationPreservesExistingDecisions(String path, String role, boolean authenticated,
String expectedRedirect) throws Exception {
new EgovUserDetailsHelper().setEgovUserDetailsService(new EgovUserDetailsService() {
@Override
public Object getAuthenticatedUser() {
return null;
}

@Override
public List<String> getAuthorities() {
return List.of(role);
}

@Override
public Boolean isAuthenticated() {
return authenticated;
}
});
AuthenticInterceptor interceptor = new AuthenticInterceptor();
// 실제 관리자 패턴 앞에 불일치 패턴을 두어 목록의 OR 매칭도 확인한다.
interceptor.setAdminAuthPatternList(List.of("/not-admin/**", "/sec/ram/*.do"));

for (String contextPath : List.of("", "/egov")) {
for (String method : List.of("GET", "POST")) {
for (boolean parsedPath : List.of(false, true)) {
HttpServletRequest request = request(contextPath, path, method);
if (parsedPath) {
ServletRequestPathUtils.parseAndCache(request);
}
String scenario = method + " " + contextPath + path + ", cached=" + parsedPath;
if (expectedRedirect == null) {
assertTrue(interceptor.preHandle(request, null, null), scenario);
} else {
ModelAndViewDefiningException exception = assertThrows(ModelAndViewDefiningException.class,
() -> interceptor.preHandle(request, null, null), scenario);
assertEquals(expectedRedirect, exception.getModelAndView().getViewName(), scenario);
}
}
}
}
}

// spring-test의 Servlet 6.0 전용 Mock 대신 Servlet 5.0에서도 동작하는 요청 스텁을 사용한다.
private static HttpServletRequest request(String contextPath, String path, String httpMethod) {
Map<String, Object> attributes = new HashMap<>();
HttpServletMapping mapping = new HttpServletMapping() {
@Override
public String getMatchValue() {
return "";
}

@Override
public String getPattern() {
return "/";
}

@Override
public String getServletName() {
return "dispatcher";
}

@Override
public MappingMatch getMappingMatch() {
return MappingMatch.DEFAULT;
}
};
return (HttpServletRequest) Proxy.newProxyInstance(AuthenticInterceptorTest.class.getClassLoader(),
new Class<?>[] { HttpServletRequest.class }, (proxy, method, args) -> {
switch (method.getName()) {
case "getMethod": return httpMethod;
case "getContextPath": return contextPath;
case "getRequestURI": return contextPath + path;
case "getServletPath": return path;
case "getPathInfo": return null;
case "getQueryString": return "pageIndex=1";
case "getHttpServletMapping": return mapping;
case "getAttribute": return attributes.get(args[0]);
case "setAttribute":
attributes.put((String) args[0], args[1]);
return null;
case "removeAttribute":
attributes.remove(args[0]);
return null;
default: throw new UnsupportedOperationException(method.getName());
}
});
}
}
Loading