[bugfix] Anchor .moderne ignore pattern so it applies at any depth - #6685
Open
duncdrum wants to merge 1 commit into
Open
[bugfix] Anchor .moderne ignore pattern so it applies at any depth#6685duncdrum wants to merge 1 commit into
duncdrum wants to merge 1 commit into
Conversation
`.moderne/*` has a slash in the middle, which anchors it to the repo root, so it only ignored the top-level .moderne/ directory. Nested .moderne/ directories created by running Moderne recipes scoped to a submodule (e.g. exist-core/.moderne/) were left untracked, showing up as a dirty checkout. Switch to `**/.moderne/*` so the ignore applies at any depth, and anchor the context/moderne.yml negations to the repo root so nested .moderne directories stay fully ignored. Closes eXist-db#6590
Contributor
📊 XQTS result comparisonComparison of this run against Warning 20 test cases were recorded in only one of the two runs (0 only in the previous run, 20 only in the current run). The runner's JUnit output is not fully deterministic (see eXist-db/exist-xqts-runner#74), so totals and per-category deltas include recording noise; the newly passing/failing lists count only tests recorded in both runs.
Relative to 🔴 Newly failing tests (2)
⚪ Recorded only in this run (20)
Runtime: 341.8s (+70.45s vs |
reinhapa
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.moderne/*(slash in the middle) is anchored to the repo root by gitignore's rules, so it only ignored the top-level.moderne/directory. Nested.moderne/directories created when running Moderne recipes scoped to a submodule (e.g.exist-core/.moderne/) were left untracked, showing up as a dirty checkout.**/.moderne/*so it applies at any depth, and anchors thecontext//moderne.ymlnegations to the repo root (!/.moderne/context/,!/.moderne/moderne.yml) so nested.modernedirs elsewhere stay fully ignored while the root's committed context files remain tracked.What Changed
.gitignore:.moderne/*→**/.moderne/*, negations anchored with a leading/.Closes #6590
Test Plan
git check-ignore -v exist-core/.moderne/apply→ now ignoredgit check-ignore -v .moderne/context/architecture.md→ still tracked (not ignored)git statusno longer reports nested.moderneworking directories as dirty