Link example bug-fix and feature PRs in PR guide - #1329
Draft
mvanhorn wants to merge 1 commit into
Draft
Conversation
Closes earthaccess-dev#530 Adds a sub-bullet under each "If you're comfortable writing tests" checkpoint in docs/contributor/pr-guide.md pointing at a representative merged PR with covering tests: - Bug-fix tab links earthaccess-dev#1015 (method resolution fix with unit + integration tests) - New-feature tab links earthaccess-dev#1198 (download() force/temp-name with unit + integration tests) Both PRs are small, single-purpose, and include new tests, matching the criteria in the issue.
mvanhorn
force-pushed
the
mvanhorn/issue-530-example-prs
branch
from
August 6, 2026 14:57
148b7ee to
6db69ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #530
What this PR does
Adds a sub-bullet under each "If you're comfortable writing tests" checkpoint in
docs/contributor/pr-guide.md, pointing at a representative merged PR with covering tests:forcekeyword + temporary-filename behavior ondownload()with new unit and integration tests).Why these PRs
The issue asks for examples that are small, explainable, and include unit tests. Both linked PRs:
tests/unit/test_store.pyplus integration coverageNotes
CHANGELOG.mdchange is included.📚 Documentation preview 📚: https://earthaccess--1329.org.readthedocs.build/en/1329/