Skip to content

Improve some miscellaneous type annotations - #1440

Open
mfisher87 wants to merge 7 commits into
mainfrom
type-info
Open

Improve some miscellaneous type annotations#1440
mfisher87 wants to merge 7 commits into
mainfrom
type-info

Conversation

@mfisher87

@mfisher87 mfisher87 commented Aug 20, 2026

Copy link
Copy Markdown
Member

Description

I just had these changes sitting around in my working copy for some reason. Figured I should just commit them!


"Ready for review" checklist

  • Place this Pull Request (PR) in draft until it is ready for review (see below)
  • Please review our Pull Request Guide
  • Mark "ready for review" after following instructions in the guide

Merge checklist

  • PR title is descriptive
  • PR body contains links to related and resolved issues (e.g. closes #1)
  • If needed, CHANGELOG.md updated
  • If needed, docs and/or README.md updated
  • If needed, unit tests added (unsure how? see below!)
  • All checks passing (tip: comment pre-commit.ci autofix if pre-commit is failing)
  • At least one approval

Need help? We welcome contributions at every experience level. You don't have to
write tests alone — open your PR and ask for help. It's also fine to let GitHub run tests
for you, via Continuous Integration (CI),
instead of running them locally. If anything fails and you're not sure why, just
mention @earthaccess-dev/maintainers in a comment and we'll work with you!


📚 Documentation preview 📚: https://earthaccess--1440.org.readthedocs.build/en/1440/

@github-actions

github-actions Bot commented Aug 20, 2026

Copy link
Copy Markdown

Binder 👈 Launch a binder notebook on this branch for commit fb3dd10

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 588db95

Binder 👈 Launch a binder notebook on this branch for commit 004a8d6

Binder 👈 Launch a binder notebook on this branch for commit f7eef07

Comment thread earthaccess/store.py

else:
logger.warning("The current session is not authenticated with NASA")
self.auth = None

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like all these type guards, but if we want to type check this code we need them because of this line -- self.auth can be None. I'd rather not do this, but the purpose of this PR is to add type information, not change behavior.

@mfisher87
mfisher87 marked this pull request as ready for review August 20, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant