Conversation
|
I will automatically update this comment whenever this PR is modified
|
mfisher87
commented
Aug 20, 2026
|
|
||
| else: | ||
| logger.warning("The current session is not authenticated with NASA") | ||
| self.auth = None |
Member
Author
There was a problem hiding this comment.
I don't like all these type guards, but if we want to type check this code we need them because of this line -- self.auth can be None. I'd rather not do this, but the purpose of this PR is to add type information, not change behavior.
mfisher87
marked this pull request as ready for review
August 20, 2026 21:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I just had these changes sitting around in my working copy for some reason. Figured I should just commit them!
"Ready for review" checklist
Merge checklist
closes #1)CHANGELOG.mdupdatedREADME.mdupdatedpre-commit.ci autofixif pre-commit is failing)📚 Documentation preview 📚: https://earthaccess--1440.org.readthedocs.build/en/1440/