Conversation
Added a note to install `scikit-learn` to encourage users away from `pip install sklearn`.
| "## Example implementation\n", | ||
| "\n", | ||
| "Let us now look at what these building blocks look like in working code example. We start off by defining the relevant parameters for a portfolio rebalancing instance, namely the number of assets and lots, the asset covariance matrix, the previous portfolio positions, the risk return factor, the normalized asset returns and the trading cost." | ||
| "Let us now look at what these building blocks look like in working code example. We start off by defining the relevant parameters for a portfolio rebalancing instance, namely the number of assets and lots, the asset covariance matrix, the previous portfolio positions, the risk return factor, the normalized asset returns and the trading cost. We will use scikit-learn (``pip install scikit-learn``) to normalize our data." |
Contributor
There was a problem hiding this comment.
Thanks for creating the PR!
I wonder if it makes more sense to add a note box for this instead.
BTW have you gone through all the code blocks in this page and made sure everything works as expected? I cannot replicate the steps that made me recreate the original issue anymore because it was some time ago.
Contributor
Author
There was a problem hiding this comment.
@purva-thakre See #795, the tutorial is broken regardless of these changes unfortunately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a note to install
scikit-learnto encourage users away frompip install sklearn.Also, removed redundant imports in the same code block
Related Issues
Closes #633
Type of Change
Breaking Change?
What was changed?
scikit-learnis used and telling users how to install it.Checklist
changelog-dev.rstReviewer Notes