QubitOperator upgrades - #857
Open
renezander90 wants to merge 2 commits into
Open
renezander90 wants to merge 2 commits into
renezander90 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Renamed coloring functions break names re-exported through the public operators API.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Optimizes Hamiltonian grouping and qubit-wise commutativity checks while preserving grouping behavior.
Changes:
- Replaces NetworkX graph construction with NumPy adjacency matrices.
- Iterates over the smaller qubit-factor dictionary during commutativity checks.
- Adds typing and documentation to grouping utilities.
File summaries
| File | Description |
|---|---|
qubit_term.py |
Optimizes qubit-wise commutativity checks. |
hamiltonian_tools.py |
Refactors graph coloring and grouping around NumPy. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
renezander90
marked this pull request as ready for review
September 14, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the performance of Hamiltonian term grouping and qubit-wise commutativity checks. It replaces NetworkX graph construction with NumPy adjacency matrices, and reduces the work performed by
QubitTerm.commute_qw()for sparse terms.Related Issues
Closes #
Related to #
Type of Change
Breaking Change?
If yes, describe the impact and migration path:
What was changed?
group_up_iterable()with a NumPy adjacency matrix.QubitTerm.commute_qw()by iterating over the smaller factor dictionary.Checklist
changelog-dev.rst