d6t: initial implementation of Omron Thermal Sensor d6t#683
d6t: initial implementation of Omron Thermal Sensor d6t#683omron-ankit wants to merge 8 commits intoeclipse-upm:masterfrom
Conversation
Signed-off-by: omron-ankit <ankit.juneja@omron.com>
Propanu
left a comment
Propanu
left a comment
There was a problem hiding this comment.
Some minor updates needed to match the documentation and JSON sensor specification. Implementation looks good to me for the most part too.
I do highly appreciate you implementing the iTemperature interface and adapting it to this sensor.
| /*=========================================================================*/ | ||
|
|
||
| namespace upm { | ||
| /** |
There was a problem hiding this comment.
These need to be updated, see https://github.com/intel-iot-devkit/upm/blob/master/docs/documentation.md#doxygen-tags
src/d6t/d6t.json
Outdated
| "Name": "API for D6T Sensor", | ||
| "Description": "This is the UPM Module for Omron MEMS D6T Thermal Sensor", | ||
| "Aliases": [""], | ||
| "Categories": [""], |
There was a problem hiding this comment.
This is a mandatory JSON attribute, look at https://raw.githubusercontent.com/intel-iot-devkit/upm/master/src/groups.md for possible values.
The JSON spec is explained in more detail here: https://github.com/intel-iot-devkit/upm/blob/master/docs/documentation.md#the-library-json-file
src/d6t/d6t.json
Outdated
| "d6t": { | ||
| "Name": "API for D6T Sensor", | ||
| "Description": "This is the UPM Module for Omron MEMS D6T Thermal Sensor", | ||
| "Aliases": [""], |
There was a problem hiding this comment.
Empty, optional attributes can be removed.
src/d6t/d6t.json
Outdated
| "Examples": { | ||
| "C++": ["d6t.cxx"] | ||
| }, | ||
| "Specifications": { |
| "default": "" | ||
| } | ||
| }, | ||
| "Platforms": { |
There was a problem hiding this comment.
Remove here as well if there are no platform notes.
| * | ||
| * @return Dummy value | ||
| */ | ||
| virtual float getTemperature(){return 0.0;} |
There was a problem hiding this comment.
Would be preferred not to hide the default interface call if possible, but it's understandable if it makes no sense for your sensor. Have you thought about maybe having this return the average of the sensor's zones? I'm thinking that would make for a quick and easy way to test if these devices power on correctly.
There was a problem hiding this comment.
Currently, we are not thinking in this direction.
2 participants
Signed-off-by: Hiroyuki Mino Hank.Mino@omron.com