Skip to content

Reject an empty deps-json instead of printing a blank table - #54

Merged
mcocdawc merged 1 commit into
mainfrom
reject-empty-dep-table-inputs
Sep 10, 2026
Merged

mcocdawc merged 1 commit into
mainfrom
reject-empty-dep-table-inputs

Conversation

@mcocdawc

@mcocdawc mcocdawc commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

eckit, eccodes and ecflow were all calling print-dep-table with a resolved-json:
input that does not exist on the action. GitHub only warns about an unknown
input, so the action ran on pure defaults — deps-json: '[]', own-name: '' — and
rendered an empty table on every build for months. An empty table reads as "this
package has no dependencies", not as "the caller wired nothing up".

required: true would not have caught it: the runner does not enforce required
for a composite action's inputs. But the action can reject an empty value itself,
which is what check-pr-label already does — so it now does.

  • deps-json loses its '[]' default and is rejected when empty. '[]' stays the
    right value for a package with no dependencies; the difference between that and
    "nothing was passed" is the whole point.
  • own-name set with an empty own-artifact-name is rejected too. That
    combination used to drop the OWN row in silence — same failure shape, one row
    smaller.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015RsLA9yt5sthqAuLFjBHdm
@mcocdawc
mcocdawc merged commit 5604cac into main Sep 10, 2026
25 checks passed
@mcocdawc
mcocdawc deleted the reject-empty-dep-table-inputs branch September 10, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant