Reject an empty deps-json instead of printing a blank table - #54
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015RsLA9yt5sthqAuLFjBHdm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eckit, eccodes and ecflow were all calling
print-dep-tablewith aresolved-json:input that does not exist on the action. GitHub only warns about an unknown
input, so the action ran on pure defaults —
deps-json: '[]',own-name: ''— andrendered an empty table on every build for months. An empty table reads as "this
package has no dependencies", not as "the caller wired nothing up".
required: truewould not have caught it: the runner does not enforcerequiredfor a composite action's inputs. But the action can reject an empty value itself,
which is what
check-pr-labelalready does — so it now does.deps-jsonloses its'[]'default and is rejected when empty.'[]'stays theright value for a package with no dependencies; the difference between that and
"nothing was passed" is the whole point.
own-nameset with an emptyown-artifact-nameis rejected too. Thatcombination used to drop the OWN row in silence — same failure shape, one row
smaller.
Contributor Declaration
By opening this pull request, I affirm the following: