docs: evaluate aggregator provider provenance - #113
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
📦 Bundle Size Analysis
|
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR appropriately documents AustLII and NZLII as evaluation-only aggregator candidates with explicit constraints that block runtime integration and redistribution. The fail-closed approach with explicit policy gates ensures legal compliance.
Critical Issue:
- Test error handling: URL construction needs try-catch to prevent unclear test failures
The documentation structure is clear, the test validates key security requirements (HTTPS-only, evaluation-only status), and the changeset properly documents the scope. Once the error handling issue is addressed, the PR will be ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
| for (const candidate of fixture.candidates) { | ||
| expect(candidate.sourceUrls.length).toBeGreaterThan(0); | ||
| for (const sourceUrl of candidate.sourceUrls) { | ||
| expect(new URL(sourceUrl).protocol).toBe('https:'); |
There was a problem hiding this comment.
🛑 Crash Risk: Wrap URL construction in try-catch to prevent cryptic test failures when encountering malformed URLs. Without error handling, the test crashes with an unhelpful error instead of clearly identifying which URL is invalid.
| expect(new URL(sourceUrl).protocol).toBe('https:'); | |
| expect(() => new URL(sourceUrl)).not.toThrow(); | |
| expect(new URL(sourceUrl).protocol).toBe('https:'); |
d3c7ce8 to
1cb8bcb
Compare
📦 Bundle Size Analysis
|
What changed
Document aggregator-provider provenance and evaluation findings.
Validation