Skip to content

Adds module for dynamic ALLOWED_HOSTS#34

Open
rehan99000 wants to merge 8 commits into
develop-multisitefrom
rehan/update-settings-override-middleware
Open

Adds module for dynamic ALLOWED_HOSTS#34
rehan99000 wants to merge 8 commits into
develop-multisitefrom
rehan/update-settings-override-middleware

Conversation

@rehan99000

Copy link
Copy Markdown

Description:
Adds module django-allowedsites for dynamic ALLOWED_HOSTS.

JIRA:
https://edlyio.atlassian.net/browse/EDLY-1493

@rehan99000 rehan99000 self-assigned this Jun 19, 2020

@zubair-arbi zubair-arbi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove extra code.

return decoded_cookie_data.get('is_course_creator', False)


class AllowedHosts(object):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this as we are using django-allowedsites app

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

setattr(settings, config_key, current_value)
else:
setattr(settings, config_key, config_value)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this extra line

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rehan99000 rehan99000 requested a review from zubair-arbi June 19, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants