feat: add support for openedx/codejail-service#72
Merged
MoisesGSalas merged 2 commits intoulmofrom Dec 8, 2025
Merged
Conversation
f47727f to
a583455
Compare
ff89a9c to
3804755
Compare
a583455 to
5d95d35
Compare
38a1ccf to
cdf49a4
Compare
cdf49a4 to
ab1b57a
Compare
Member
Author
|
Hey @feanil, this are the changes that I made in order to support the new codejail-service made by 2U. I would say that the only thing to keep in mind would be forcing operators to run ubuntu 24.04, and also the 2U service is more strict regarding the AppArmor configuration, and won't even start if not properly secured. FYI @timmc-edx |
|
Other compat notes: The 2U version also removes the |
8df5e58 to
0d0a4ff
Compare
Member
Author
|
I merged this into the Ulmo branch. I asked on the BTR slack channel for this changes and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces support for https://github.com/openedx/codejail-service.
I decided to introduce a few variables that will only be available during the Ulmo release to ease the transition. Mainly
CODEJAIL_USE_SERVICE_V2that use the appropriate configuration for the new Django service and also build with the new dockerfile.I took the Dockerfile from https://github.com/edx/public-dockerfiles/blob/main/dockerfiles/codejail-service.Dockerfile with some minor adjustements:
tutor images build codejail -a SANDBOX_DEPS_SRC_FILE=release/quince.txt)--no-log-initto avoid creating extremely large images (see: Fix: Large DEV Image overhangio/tutor#918).I tested this both on docker and kubernetes. Both hosts where using Ubuntu 24.04. I did two tests: I imported https://github.com/mitodl/mitx-grading-library/tree/master/course and check that a few units where working correctly. I also ran the tests in https://github.com/openedx/codejail-service/tree/main/api_tests and all of them passed.