Skip to content

Potential fix for code scanning alert no. 16: Missing rate limiting #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eduappsec1 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Potential fix for code scanning alert no. 16: Missing rate limiting #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b28d8b
Potential fix for code scanning alert no. 16: Missing rate limiting
eduappsec1 Jul 17, 2025
c558143
Update security.yaml
eduappsec1 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/security.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Bearer

on: [pull_request]
on: #[pull_request]
workflow_dispatch:

permissions:
contents: read
Expand Down
3 changes: 2 additions & 1 deletion src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"express-session": "^1.17.3",
"mongodb": "^4.9.1",
"morgan": "~1.10.0",
"redis": "^4.3.1"
"redis": "^4.3.1",
"express-rate-limit": "^8.0.1"
},
"devDependencies": {
"eslint": "^8.23.1",
Expand Down
10 changes: 9 additions & 1 deletion src/todo/routes.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@ import express from 'express'
const router = express.Router()
import { MongoClient, ObjectId } from 'mongodb'
import appInsights from 'applicationinsights'
import rateLimit from 'express-rate-limit'

// Configure rate limiter: maximum of 100 requests per 15 minutes
const apiLimiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100, // limit each IP to 100 requests per windowMs
message: { error: 'Too many requests, please try again later.' }, // Custom error message
})

const DBNAME = process.env.TODO_MONGO_DB || 'todoDb'
const COLLECTION = 'todos'
Expand Down Expand Up @@ -99,7 +107,7 @@ router.put('/api/todo/:id', async function (req, res, next) {
//
// Todo API: DELETE - remove a todo from DB
//
router.delete('/api/todo/:id', async function (req, res, next) {
router.delete('/api/todo/:id', apiLimiter, async function (req, res, next) {
try {
const result = await db.collection(COLLECTION).deleteOne({ _id: ObjectId(req.params.id) })
if (result && result.deletedCount) {
Expand Down