Conversation
Member
|
I have a hard time seeing the actual changes on my phone because the GitHub app does not have the option to ignore whitespace changes. Any chance splitting this PR up in a formatting followed by the change or the other way around? Whatever is simpler. |
This prevents endpoints serving non-latin scripts to display properly. Without the UTF-8 encoding the encoding will be interpreted as something else, resulting in so-called mojibake.
Contributor
Author
|
Redid it. If you want I can open a prettier PR in a bit? |
line-o
reviewed
Sep 1, 2026
line-o
left a comment
line-o
left a comment
Member
There was a problem hiding this comment.
I am in favour of pulling this in. I would like to discuss some details beforehand, though.
Could you have a look at my comments?
DrRataplan
force-pushed
the
charsets
branch
2 times, most recently
from
September 1, 2026 09:11
c126c31 to
016e8ae
Compare
Member
|
The tests do no longer pass @DrRataplan :/ |
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents endpoints serving non-latin scripts to display properly. Without the UTF-8 encoding the encoding will be interpreted as something else, resulting in so-called mojibake.