Skip to content

Prevent multiline tool titles from overlapping activity details - #181

Open
AmAzing129 wants to merge 2 commits into
egoist:mainfrom
AmAzing129:fix/multiline-tool-titles
Open

AmAzing129 wants to merge 2 commits into
egoist:mainfrom
AmAzing129:fix/multiline-tool-titles

Conversation

@AmAzing129

Copy link
Copy Markdown

Problem

Some providers can replace a tool's short display title with the complete command when the tool finishes. When that command contains newlines or tabs, Waku kept the whitespace-containing title verbatim.

Activity headers have a fixed height, but the title content was not constrained to that header. Collapsed cards happened to hide the overflow; expanding a card made the multiline title paint over the Arguments and Output sections.

Solution

  • Collapse whitespace runs in provider-supplied, human-readable tool names to a single space. This only changes the display title; the original activity payload, arguments, and output remain untouched.
  • Keep both grouped and individual activity headers fixed and clipped so malformed provider labels cannot escape into adjacent content.
  • Apply the same title normalization to the web transcript presentation and add regression coverage for newline/tab input.

Verification

  • cargo test --package waku generic_tool_rows_collapse_multiline_provider_names --locked
  • bun test apps/web/src/lib/transcript-presentation.test.ts
  • bun run --filter @waku/web typecheck
  • Manually verified in Waku Debug.app with the persisted session that originally reproduced the overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant