Prevent multiline tool titles from overlapping activity details - #181
Open
AmAzing129 wants to merge 2 commits into
Open
AmAzing129 wants to merge 2 commits into
AmAzing129 wants to merge 2 commits into
Conversation
# Conflicts: # apps/web/src/lib/transcript-presentation.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some providers can replace a tool's short display title with the complete command when the tool finishes. When that command contains newlines or tabs, Waku kept the whitespace-containing title verbatim.
Activity headers have a fixed height, but the title content was not constrained to that header. Collapsed cards happened to hide the overflow; expanding a card made the multiline title paint over the Arguments and Output sections.
Solution
Verification
cargo test --package waku generic_tool_rows_collapse_multiline_provider_names --lockedbun test apps/web/src/lib/transcript-presentation.test.tsbun run --filter @waku/web typecheckWaku Debug.appwith the persisted session that originally reproduced the overlap.