fix(skills): discover Grok skill and command roots - #235
Open
qinghuanandejiangshi wants to merge 1 commit into
Open
qinghuanandejiangshi wants to merge 1 commit into
qinghuanandejiangshi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and solution
Grok skills under
.grok/skillswere invisible to the Skills library and slash picker. This adds the project and user roots, reuses the existingGROK_HOMEresolver, and adds Grok to the desktop source filter. Native command markdown is discovered too; commands remain passthrough. Skills markeduser-invocable: falseremain manageable in the library but stay out of the Grok slash picker.Checks
GROK_HOME, project precedence, native commands, disable/re-enable and non-invocable skills.cargo checkpassed. Both used--features gpui_platform/runtime_shadersbecause this Mac lacks the Metal compiler.bun run protocol:check, and client typecheck passed; client tests: 23 passed.Limitations and follow-up
No authenticated Grok session or live model request was used; slash discovery and submission were verified by automated tests, not a live session UI. The normal development bundle failed in the local Swift toolchain (
swift-packagemissing a BuildServerProtocol symbol). UI validation used the watcher with a temporary signed UI-only bundle, omitting computer-use/updater helpers. The packaging script was restored and is not part of this PR. No wire types changed.Related issue
Fixes #170
AI disclosure
OpenAI Codex implemented the change, wrote and ran tests, inspected the native UI, and drafted this description at the submitter's request. This description is AI-generated; it is not represented as independently human-written.
Checklist