Repository navigation
Support the v1beta1 version of ETOS environments - #95
Merged
Merged
Conversation
This was referenced Jun 18, 2026
t-persson
marked this pull request as ready for review
June 24, 2026 11:49
andmat900
reviewed
Jul 28, 2026
t-persson
force-pushed
the
v1beta1-execution
branch
from
September 18, 2026 12:10
cb32fe8 to
08bb652
Compare
Collaborator
Author
|
Rebase. No comments fixed. |
This change converts all environments (or sub suites) to the v1beta1 version of the EnvironmentSpec and updates the executor and testrunners to be able to run this version.
t-persson
force-pushed
the
v1beta1-execution
branch
from
September 21, 2026 11:14
08bb652 to
844ddba
Compare
Collaborator
Author
|
Rebased and ready for review again |
andmat900
requested changes
Sep 22, 2026
andmat900
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable Issues
eiffel-community/etos#661
depends-on: eiffel-community/etos-library#68
Description of the Change
This change converts all environments (or sub suites) to the v1beta1 version of the EnvironmentSpec and updates the executor and testrunners to be able to run this version.
Alternate Designs
I started by refactoring the entirety of the ETR to stop using the ETOS library config and instead pass around variables.
The change was good, but it created a much larger change than I think we want so I put that on the back-burner and instead focused on creating a change that works with the new format.
Possible Drawbacks
One thing that I noticed, which is not really related to the ETR per-se, is that we pass a specific ETOS API version down to the ETR from the execution space providers. It is also expected that custom execution space providers know this and pass down the correct one as well. I don't have a solution yet and the solution might not be in the ETR.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson tobias.persson@axis.com