Allow crop selection to reach the right and bottom edges - #221
Merged
Merged
Conversation
This was referenced Sep 11, 2026
ekisu
force-pushed
the
fix/issue-140
branch
from
September 12, 2026 00:53
150f97e to
25444ee
Compare
ekisu
force-pushed
the
fix/issue-140
branch
from
September 12, 2026 00:55
25444ee to
10c8555
Compare
…s are inclusive indices while bottom_right is an exclusive bound the cursor can never reach. Snap the last OSD pixel to the exclusive video edge so dragging to the frame edge yields the full width/height. Interior mapping unchanged; reverse drag also yields full frame.
ekisu
force-pushed
the
fix/issue-140
branch
from
September 12, 2026 01:15
10c8555 to
052fb0c
Compare
Owner
Author
|
Approved. |
ekisu
marked this pull request as ready for review
September 12, 2026 19:29
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Snap the last displayed pixel to the exclusive video boundary so mouse-based crop selection can include the full right/bottom edge. Interior coordinate mapping is preserved.
Fixes #140
Tracked in #217.
Verification
At downscaled edges, the last screen pixel snaps to the full source boundary. Manual desktop interaction remains for review.
Current harness-based verification (supersedes historical test notes)
Rebased onto master
72d9d11, which includes #226 and #227. Tests load the normal built script and drive real mpv.Four real Xvfb GUI tests cover full-frame/reverse selection, downscaling, letterboxing, and interior cropping with encoded dimensions. Unfixed script yields 639x359 instead of 640x360; edge regressions fail before the fix and pass afterward. Pinned Nix: 18 tests, 17 passed, 1 existing audio skip.
Latest rebase verification
Rebased onto master
72d9d11after #227 merged. Normal build and the complete pinned-Nix suite pass, with two expected skips (audio fixture and unavailable optional libaom-av1 encoder).