Skip to content

test: fix @opentelemetry/api TAV tests - #5201

Merged
david-luna merged 1 commit into
mainfrom
otel-api-tav-tests
Sep 9, 2026
Merged

david-luna merged 1 commit into
mainfrom
otel-api-tav-tests

Conversation

@david-luna

Copy link
Copy Markdown
Member

peer dependencies in @opentelemetry/metrics-sdk was changed in open-telemetry/opentelemetry-js#5254 to "@opentelemetry/api": ">=1.9.0 <1.10.0"

So when TAV tests try to install an API version prior to 1.9.0 in https://github.com/elastic/apm-agent-nodejs/tree/main/test/opentelemetry-metrics/fixtures it gives an install failure and TAV tests fail. This PR sets the right peer dependencies.

Checklist

@david-luna
david-luna requested a review from a team as a code owner September 8, 2026 23:07
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@david-luna david-luna left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @opentelemetry/api

@david-luna
david-luna enabled auto-merge (squash) September 8, 2026 23:11
@david-luna david-luna changed the title test: fix otel API TAV tests test: fix @opentelemetry/api TAV tests Sep 8, 2026
@david-luna
david-luna merged commit 4102c8e into main Sep 9, 2026
28 of 30 checks passed
@david-luna
david-luna deleted the otel-api-tav-tests branch September 9, 2026 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants