fix: include extraction counters in sync progress logs (#4469) - #4471
Open
Jan-Kazlouski-elastic wants to merge 2 commits into
Open
fix: include extraction counters in sync progress logs (#4469)#4471Jan-Kazlouski-elastic wants to merge 2 commits into
Jan-Kazlouski-elastic wants to merge 2 commits into
Conversation
Contributor
Author
|
Validated locally with real connector ftest ( Second sync (re-index after small delete): Also ran under Perf8 ( Unit tests: 2445 passed. |
artem-shelkovnikov
approved these changes
Sep 11, 2026
artem-shelkovnikov
left a comment
Member
There was a problem hiding this comment.
It's okay, but I'm a little on the fence - judgement is up to you.
This log like is pretty spammy, so increasing the size of the line 2x increases total logs produced by a sync 2x.
It should not be a big problem, since we don't really count/declare what's the expected log throughput though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4469
Sync progress logs were emitted every
display_everydocuments read, but only reported queued create/update/delete totals. During runs that skip unchanged or filtered documents, this produced bursts of byte-identical log lines that looked like duplication or a stalled sync.This change enriches progress messages with
extracted,filtered, andskippedcounters, and aligns counter tracking across all extractor code paths (get_docs,get_docs_incrementally,get_access_control_docs).Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)Changes Requiring Extra Attention
Related Pull Requests
Release Note
Sync progress logs now include extracted, filtered, and skipped document counts so agentless connector logs no longer show misleading duplicate progress lines during fast-skipping syncs.