Skip to content

[9.4] fix(sharepoint): add compact site-group DLS mode to reduce ACL memory (#4396) #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jan-Kazlouski-elastic merged 1 commit into from
Sep 18, 2026
Merged

[9.4] fix(sharepoint): add compact site-group DLS mode to reduce ACL memory (#4396) #4499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion app/connectors_service/connectors/sources/sharepoint/sharepoint_online/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,20 @@ async def site_admins(self, site_web_url):
self._logger.debug(f"No site admins found for site: '${site_web_url}'")
return

async def site_groups(self, site_web_url):
self._validate_sharepoint_rest_url(site_web_url)

select_ = "Id,Title"
url = f"{site_web_url}/_api/web/sitegroups?$select={select_}"

try:
async for page in self._rest_api_client.scroll(url):
for site_group in page:
yield site_group
except NotFound:
self._logger.debug(f"No site groups found for site: '{site_web_url}'")
return

async def site_groups_users(self, site_web_url, site_group_id):
self._validate_sharepoint_rest_url(site_web_url)

Expand All @@ -694,7 +708,7 @@ async def active_users_with_groups(self):
expand = "transitiveMemberOf($select=id)"
top = 999 # this is accepted, but does not get taken literally. Response size seems to max out at 100
filter_ = "accountEnabled eq true"
select = "UserName,userPrincipalName,Email,mail,transitiveMemberOf,id,createdDateTime"
select = "UserName,userPrincipalName,Email,mail,transitiveMemberOf,id,createdDateTime,userType"
url = f"{GRAPH_API_URL}/users?$expand={expand}&$top={top}&$filter={filter_}&$select={select}"

try:
Expand Down
Loading