Skip to content

pull-requests.json: update the skip_ci if no product or BK specific - #7846

Closed
v1v wants to merge 1 commit into
mainfrom
v1v-patch-2
Closed

v1v wants to merge 1 commit into
mainfrom
v1v-patch-2

Conversation

@v1v

@v1v v1v commented Sep 17, 2026

Copy link
Copy Markdown
Member

What is the problem this PR solves?

Run faster builds if no product changes

How does this PR solve the problem?

By honouring the javascript regex supported by the BK PR Bot, see https://github.com/elastic/kibana/blob/main/.buildkite/pull_requests.json#L27C18-L28C23

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@v1v
v1v requested a review from a team September 17, 2026 15:44
@v1v v1v self-assigned this Sep 17, 2026
@v1v
v1v requested a review from a team as a code owner September 17, 2026 15:44
@v1v
v1v requested review from macdewee and swiatekm and a lite review from Copilot September 17, 2026 15:44
@v1v v1v added backport-skip Skip notification from the automated backport with mergify skip-changelog labels Sep 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed regex updates are focused and have no unresolved blocking issues.

Pull request overview

Updates Buildkite skip-CI regexes to correctly match dot-prefixed paths.

Changes:

  • Escapes literal dots in relevant CI and configuration path patterns.
  • Preserves existing skip behavior for non-product changes.
File summaries
File Description
.buildkite/pull-requests.json Corrected skip-CI regex patterns.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

TL;DR

Both failed jobs are cloud E2E jobs that should likely not have run for this PR, and one of them clearly fails due to an empty Fleet URL. Add .buildkite to skip_ci_on_only_changed and rerun; if FIPS still fails, capture the full cloudE2ERun section to isolate that second failure.

Remediation

  • Update .buildkite/pull-requests.json so CI-only edits under .buildkite/ are skipped by skip_ci_on_only_changed (for this PR, add ^\\.buildkite/ alongside the existing skip patterns).
  • Keep the regex escaping fix in this PR, then rerun Buildkite after the skip list update.
  • If :gcloud: Cloud e2e FIPS Test still fails after rerun, collect the full pre-cleanup part of that log (the current artifact only shows teardown and generic exit status 1).
Investigation details

Root Cause

  1. Cloud e2e Test shows fleet_url was empty in Terraform outputs, which matches an explicit hard-fail path in .buildkite/scripts/cloud_e2e_test.sh.
    • Script evidence: .buildkite/scripts/cloud_e2e_test.sh:35-44 exits with status 1 when FLEET_SERVER_URL == "".
    • Log evidence: /tmp/gh-aw/buildkite-logs/fleet-server-gcloud-cloud-e2e-test.txt includes fleet_url = "" -> null before teardown.
  2. Cloud e2e FIPS Test log artifact contains only teardown tail plus generic exit status 1; it does not include the earlier failing command output, so the exact failing assertion/step is not observable from provided data.
  3. PR scope is only .buildkite/pull-requests.json, but skip_ci_on_only_changed currently does not include .buildkite/ paths (.buildkite/pull-requests.json:13). That means heavy cloud jobs still run for this CI-config-only change.

Evidence

  • Build: https://buildkite.com/elastic/fleet-server/builds/16955
  • Jobs/steps:
    • :gcloud: Cloud e2e Test (.buildkite/scripts/cloud_e2e_test.sh)
    • :gcloud: Cloud e2e FIPS Test (.buildkite/scripts/cloud_e2e_test.sh)
  • Key log excerpts:
    • fleet-server-gcloud-cloud-e2e-test.txt: fleet_url = "" -> null
    • fleet-server-gcloud-cloud-e2e-fips-test.txt: 🚨 Error: The command exited with status 1 (no earlier failing command shown in artifact)

Verification

  • Not run locally (cloud environment + Buildkite-only execution path).

Follow-up

  • I checked open flaky-test issues and did not find a matching existing issue for the observed FLEET_SERVER_URL is empty failure mode in this build.

What is this? | From workflow: Observability Agentic Workflow — Status

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@v1v v1v closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Skip notification from the automated backport with mergify skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants