Conversation
Run faster builds if no product changes
v1v
requested review from
macdewee and
swiatekm
and
a lite review from Copilot
September 17, 2026 15:44
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed regex updates are focused and have no unresolved blocking issues.
Pull request overview
Updates Buildkite skip-CI regexes to correctly match dot-prefixed paths.
Changes:
- Escapes literal dots in relevant CI and configuration path patterns.
- Preserves existing skip behavior for non-product changes.
File summaries
| File | Description |
|---|---|
.buildkite/pull-requests.json |
Corrected skip-CI regex patterns. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
TL;DRBoth failed jobs are cloud E2E jobs that should likely not have run for this PR, and one of them clearly fails due to an empty Fleet URL. Add Remediation
Investigation detailsRoot Cause
Evidence
Verification
Follow-up
What is this? | From workflow: Observability Agentic Workflow — Status Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Run faster builds if no product changes
How does this PR solve the problem?
By honouring the javascript regex supported by the BK PR Bot, see https://github.com/elastic/kibana/blob/main/.buildkite/pull_requests.json#L27C18-L28C23
How to test this PR locally
Design Checklist
Checklist
./changelog/fragmentsusing the changelog toolRelated issues