-
Notifications
You must be signed in to change notification settings - Fork 51
[Feature] Add interactive mode to demo.sh with deployment type selection #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
interactive mode
|
There's a failure in the k8s tests, but the CI output isn't very helpful. Could we try to display appropriate logs when that happens? |
|
If I run |
services from docker compose instead of having to maintain a separate list
This reverts commit 0a64942.
failure information to be shown
test failure information to be shown
We can indeed, I had a look at the bashunit docs and have updated the tests with some custom assertions, see bashunit docs here. |
exits, if they do we reuse them
Good spot, I have updated |
|
k8s integration tests have been skipped as there is an issue with the helm charts in elastic-agent atm: Running test/elastic/basic_k8s_test.sh
↷ Skipped: Launch demo k8s K8s test disabled: helm chart null mapping issue
↷ Skipped: Destroy demo k8s K8s test disabled: helm chart null mapping issueThere is an open PR to fix this -> elastic/elastic-agent#11481 |
rogercoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, just added some comments to avoid upstream conflicts
| sudo rm -rf /usr/share/dotnet | ||
| sudo rm -rf /usr/local/lib/android | ||
| sudo rm -rf /opt/ghc | ||
| sudo rm -rf /opt/hostedtoolcache/CodeQL | ||
| docker system prune -af --volumes | ||
| sudo apt-get clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Did we reach any resource limit? Maybe run the test on a smaller distro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup this free's up space as the k8s test run fails due to insuffienent space. I tried a few different options, including running ubuntu-slim and using the maximize-build-disk-space. They failed due to ubuntu-slim not having docker installed and the maximize-build-disk-space fails due to kind erroring out on install.
I also have updated the elastic stack install to only install elasticsearch and not kibana, see here. That helped a bit but I still needed 1GB of space.
I followed this blog and updated the disc clean up. I think for now this is our only option.
workflows to allow space on the VM to run the docker and k8s tests, also we install bashunit at bin, not lib.
integration tests
reason we need this is the standard option runs out of resources for the k8s test run
to reduce the resource overhead
Changes
This PR add's an interactive mode when running
demo.sh, this interactive mode prompts the user to enter the following:serverlessorcloud-hosteddockerork8sThis PR also add's integration tests that run in the PR's CI.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.