Skip to content

fix: correctly log makeappx.exe errors #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickzhao merged 2 commits into from
Nov 10, 2025
Merged

fix: correctly log makeappx.exe errors #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d84423b
fix: correctly log `MakeAppx` errors
erickzhao Nov 6, 2025
72f2269
fixes
erickzhao Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
220 changes: 116 additions & 104 deletions src/bin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,104 +1,116 @@
import { sign as windowsSign, SignOptions } from "@electron/windows-sign";
import { spawn } from 'child_process';

import { log } from "./logger";
import { ProgramOptions } from "./types";

const run = async (executable: string, args: Array<string>) => {
return new Promise<string>((resolve, reject) => {
const proc = spawn(executable, args, {});
log.debug(`Calling ${executable} with args`, args);

const cleanOutData = (data: any) => {
return data
.toString()
.replace(/\r/g, '')
.replace(/\\\\/g, '\\')
.split('\n')
}

let stdout = "";
proc.stdout.on('data', (data) => {
stdout += data;
});

let stderr = "";
proc.stderr.on('data', (data) => {
stderr += data;
});

proc.on('exit', (code: number) => {
log.debug(`stdout of ${executable}`, cleanOutData(stdout));
if (code !== 0) {
log.error(`stderr of ${executable}`, false, cleanOutData(stderr))
return reject(new Error(`Failed running ${executable} Exit Code: ${code} See previous errors for details`))
}
return resolve(stdout);
});

proc.stdin.end();
})
}

export const getCertPublisher = async (cert: string, cert_pass: string) => {
const args = [];
args.push('-p', cert_pass);
args.push('-dump', cert);
const certDump = await run('certutil', args);
const subjectRegex = /Subject:\s*(.*)/;
const match = certDump.match(subjectRegex);
const publisher = match ? match[1].trim() : null;
if(!publisher) {
log.error('Unable to find publisher in Cert');
}
return publisher;
}

export const priConfig = async (program: ProgramOptions) => {
const { makePri, priConfig, createPri } = program;
if(createPri) {
const args = ['createconfig', '/cf', priConfig, '/dq', 'en-US'];
log.debug('Creating pri config.')
await run(makePri, args);
} else {
log.debug('Skipping making pri config.');
}
}

export const pri = async (program: ProgramOptions) => {
const { makePri, priConfig, layoutDir, priFile, appManifestLayout, createPri } = program;
if(createPri) {
log.debug('Making pri.')
const args = ['new', '/pr', layoutDir, '/cf', priConfig, '/mn', appManifestLayout, '/of', priFile, '/v'];
await run(makePri, args);
} else {
log.debug('Skipping making pri.');
}
}

export const make = async (program: ProgramOptions) => {
const { makeMsix, layoutDir, msix, isSparsePackage} = program;
const args = [
'pack',
'/d',
layoutDir,
'/p',
msix,
'/o',
];

if(isSparsePackage) {
args.push('/nv');
}
await run(makeMsix, args);
}

export const sign = async (program: ProgramOptions) => {
if(program.sign) {
const signOptions = program.windowsSignOptions;
log.debug('Signing with options', signOptions);
await windowsSign(signOptions as SignOptions);
} else {
log.debug('Skipping signing.');
}
}
import { sign as windowsSign, SignOptions } from "@electron/windows-sign";
import { spawn } from 'child_process';

import { log } from "./logger";
import { ProgramOptions } from "./types";

const run = async (executable: string, args: Array<string>) => {
return new Promise<string>((resolve, reject) => {
const proc = spawn(executable, args, {});
log.debug(`Calling ${executable} with args`, args);

const cleanOutData = (data: any) => {
return data
.toString()
.replace(/\r/g, '')
.replace(/\\\\/g, '\\')
.split('\n')
}

let stdout = "";
proc.stdout.on('data', (data) => {
stdout += data;
});

let stderr = "";
proc.stderr.on('data', (data) => {
stderr += data;
});

proc.on('exit', (code: number) => {
if (code === 0) {
log.debug(`stdout of ${executable}`, cleanOutData(stdout));
return resolve(stdout);
} else {
if (stderr !== '') {
log.error(`stderr of ${executable}`, false, cleanOutData(stderr));
}

if (stdout !== '') {
log.error(`stdout of ${executable}`, false, cleanOutData(stdout));
}
return reject(
new Error(
`Failed running ${executable} Exit Code: ${code} See previous errors for details`
)
);

}
});

proc.stdin.end();
})
}

export const getCertPublisher = async (cert: string, cert_pass: string) => {
const args = [];
args.push('-p', cert_pass);
args.push('-dump', cert);
const certDump = await run('certutil', args);
const subjectRegex = /Subject:\s*(.*)/;
const match = certDump.match(subjectRegex);
const publisher = match ? match[1].trim() : null;
if(!publisher) {
log.error('Unable to find publisher in Cert');
}
return publisher;
}

export const priConfig = async (program: ProgramOptions) => {
const { makePri, priConfig, createPri } = program;
if(createPri) {
const args = ['createconfig', '/cf', priConfig, '/dq', 'en-US'];
log.debug('Creating pri config.')
await run(makePri, args);
} else {
log.debug('Skipping making pri config.');
}
}

export const pri = async (program: ProgramOptions) => {
const { makePri, priConfig, layoutDir, priFile, appManifestLayout, createPri } = program;
if(createPri) {
log.debug('Making pri.')
const args = ['new', '/pr', layoutDir, '/cf', priConfig, '/mn', appManifestLayout, '/of', priFile, '/v'];
await run(makePri, args);
} else {
log.debug('Skipping making pri.');
}
}

export const make = async (program: ProgramOptions) => {
const { makeMsix, layoutDir, msix, isSparsePackage} = program;
const args = [
'pack',
'/d',
layoutDir,
'/p',
msix,
'/o',
];

if(isSparsePackage) {
args.push('/nv');
}
await run(makeMsix, args);
}

export const sign = async (program: ProgramOptions) => {
if(program.sign) {
const signOptions = program.windowsSignOptions;
log.debug('Signing with options', signOptions);
await windowsSign(signOptions as SignOptions);
} else {
log.debug('Skipping signing.');
}
}