Debug failing CI on quote-pub branch #23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the CI failures by ensuring the dev certificate subject matches the manifest Publisher attribute format. The manifest template wraps the publisher name in quotes (CN="Publisher Name"), so the dev cert must also be created with a quoted subject. Changes: - Updated create_dev_cert.ps1.in to create certs with quoted subjects - Updated all test fixture manifests to use quoted publisher format - Updated test expectations to match quoted format - Added script to regenerate test certificates Note: The test certificate (test/e2e/fixtures/MSIXDevCert.pfx) needs to be regenerated on Windows by running: test/e2e/scripts/generate_test_cert.ps1 This ensures makeappx.exe validation passes when comparing the manifest Publisher attribute with the certificate subject.
MarshallOfSound
deleted the
claude/debug-quote-pub-ci-01XJy7PcfY4f5S4qXNxDLbAA
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe?