Reproduce #1911 with failing tests only (no fix, not for merge) - #1930
Closed
jasperblues wants to merge 1 commit into
Closed
Reproduce #1911 with failing tests only (no fix, not for merge)#1930jasperblues wants to merge 1 commit into
jasperblues wants to merge 1 commit into
Conversation
Tests only, on top of main. 13 of 21 fail, which is the point: the defect is reproducible from configuration a deployment can reach, without reading any of the argument for it. Not for merge. #1912 carries the same tests plus the fix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
#1911 was merged. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduces #1911. Tests only, no fix. Not for merge.
The tests from #1912, applied to
main. Nothing else changed.1. Tests alone on
main— 13 of 21 fail2. #1912 on top — 31 of 31 pass
31 rather than 21 because the merge brings
AgentProcessAccessorTest.With, which needswith()to compile.The 8 that pass in step 1 matter too.
OwnedExecutorsNeverRunOnTheCallergreen both ways is the evidence for "virtual threads cannot hit this";PooledThreadIsolationgreen both ways is the evidence this is not "just stop cleaning up". All 21 red would prove too much.AgentProcessAccessorTest.Withis excluded here on purpose — it callswith(), which #1912 adds, so onmainit fails to compile. A compile error proves nothing about behaviour.Read counts from the surefire XML;
rerunFailingTestsCountmakes the console summary double-count.