Improve redaction annotation to remove more#488
Open
JoackimPennerup wants to merge 2 commits intoembedpdf:mainfrom
Open
Improve redaction annotation to remove more#488JoackimPennerup wants to merge 2 commits intoembedpdf:mainfrom
JoackimPennerup wants to merge 2 commits intoembedpdf:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@bobsingor Any change you could have a look at this? I'd be happy to change it into another direction if you'd like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens annotation-mode redaction to better match Acrobat-style behavior for applied redactions and to reduce residual sensitive data in annotations/forms.
What changed
REDACT.inReplyToIdtraversal seeded from applied REDACT IDs.rectsIntersect(a, b)in@embedpdf/modelsand exported it.setFormFieldValue(..., { kind: 'checked', isChecked })now toggles only when current state differs from requested state (idempotent set-to-target behavior).Important behavior notes
Tests
Added/updated tests covering:
rectsIntersect)Validation
pnpm --filter @embedpdf/plugin-redaction test✅pnpm --filter @embedpdf/models test✅pnpm --filter @embedpdf/engines test✅Out of scope / follow-up