fix(plugin-scroll): horizontal layout extent, centering and programmatic scroll#541
Merged
bobsingor merged 4 commits intoMar 25, 2026
Conversation
…tic scroll BREAKING CHANGE: none - Use scroll-axis extent (width vs height) for visible range and end spacing so horizontal mode no longer treats item height as the scroll extent. - Disable horizontal centering (getCenteringOffsetX → 0) so pages stay in a plain row; vertical keeps centering via total content width. - During pageChangeState.isChanging, keep store currentPage from viewport- derived metrics and avoid duplicate pageChange$ until user-driven scroll resumes; startPageChange sets currentPage + emits pageChange$ optimistically. - In commitMetrics, dispatch before scroll$.emit so listeners that read state see metricsToCommit (single source of truth). - Set PageLayout.elevated: false when building virtual items (required field; selectors still override from interaction manager).
|
@luissardon is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #538
BREAKING CHANGE: none