Working toward glimmer-vm repo integration #20908
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Try to make a test to prevent #1688 (and other prettier breakages) * Seems fine so far... * Add node testing to CI * delete unused file * Remove mention of run-node-tests * Why isn't linting working? * As I feared, we have the build wrong * idk man * run pnpm repo:update:metadata * Lints -- these are actually all correct * Fix #1688 * Move test project into a real project, rather than tmp for easier poking around * Set vitest conditions * Curious * Fix node smoke * Remove extraneous test * Why doesn't my local CLI env match CI * lockfile * different logging * Now its working? * Codify the requirements for running the types check * More turbo progress * omg it worked * Maybe I just remove the local lint script * Don't need that anymore * Fix * Updates * fix * last fix?
Co-authored-by: NullVoxPopuli <[email protected]>
Fix @glimmer/interfaces, we were not publishing anything
Prepare Release
Update package meta post-publish and tell the auto-publish infra to do this for us
Fix exports
Prepare Release
Re-enable CJS for @glimmer/compiler (used by babel plugin)
Prepare Release
Rollup the types (solves missing types from unpublished packages)
…d-on-build-tools Add README to @glimmer/interfaces to try to force a release of dependent packages
Estimated Asset SizesDiff --- main/out.txt 2025-12-16 20:19:28.000000000 +0000
+++ pr/./pr-20284114979/out.txt 2025-12-16 22:03:08.000000000 +0000
@@ -1,62 +1,62 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 416.91 KB │ 231.03 KB ║
+║ Total │ 352.07 KB │ 203.52 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 238.18 KB │ 146.56 KB ║
+║ Total │ 313.81 KB │ 181.76 KB ║
╟──────────────────────┼───────────┼───────────╢
-║ -internals │ 34.71 KB │ 24.96 KB ║
-║ application │ 12.7 KB │ 7.6 KB ║
-║ array │ 12.63 KB │ 7.3 KB ║
+║ -internals │ 36.61 KB │ 26.02 KB ║
+║ application │ 13.24 KB │ 8 KB ║
+║ array │ 13.05 KB │ 7.54 KB ║
║ canary-features │ 304 B │ 419 B ║
-║ component │ 1.07 KB │ 1005 B ║
-║ controller │ 1.8 KB │ 1.36 KB ║
-║ debug │ 11.36 KB │ 7.92 KB ║
+║ component │ 2.05 KB │ 1.58 KB ║
+║ controller │ 1.96 KB │ 1.45 KB ║
+║ debug │ 11.73 KB │ 8.14 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 599 B ║
-║ instrumentation │ 2.43 KB │ 1.77 KB ║
-║ modifier │ 669 B │ 586 B ║
-║ object │ 33.74 KB │ 20.66 KB ║
+║ helper │ 1.08 KB │ 795 B ║
+║ instrumentation │ 2.43 KB │ 1.78 KB ║
+║ modifier │ 1.22 KB │ 962 B ║
+║ object │ 35.98 KB │ 22.1 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 406 B │ 353 B ║
-║ routing │ 58.04 KB │ 33.41 KB ║
-║ runloop │ 2.2 KB │ 1.33 KB ║
-║ service │ 859 B │ 741 B ║
-║ template │ 430 B │ 370 B ║
+║ renderer │ 630 B │ 483 B ║
+║ routing │ 59.37 KB │ 34.01 KB ║
+║ runloop │ 2.36 KB │ 1.5 KB ║
+║ service │ 1 KB │ 858 B ║
+║ template │ 654 B │ 544 B ║
║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 57.71 KB │ 30.53 KB ║
-║ template-factory │ 94 B │ 160 B ║
+║ template-compiler │ 123.33 KB │ 59.59 KB ║
+║ template-factory │ 370 B │ 363 B ║
║ test │ 923 B │ 627 B ║
-║ utils │ 3.93 KB │ 3.5 KB ║
+║ utils │ 4.11 KB │ 3.63 KB ║
║ version │ 55 B │ 131 B ║
╚══════════════════════╧═══════════╧═══════════╝
-╔═════════════════╤═══════════╤══════════╗
-║ @glimmer/* │ Min │ Gzip ║
-╟─────────────────┼───────────┼──────────╢
-║ Total │ 178.73 KB │ 84.47 KB ║
-╟─────────────────┼───────────┼──────────╢
-║ destroyable │ 2.69 KB │ 1.3 KB ║
-║ encoder │ 596 B │ 653 B ║
-║ env │ 38 B │ 87 B ║
-║ global-context │ 886 B │ 545 B ║
-║ manager │ 12.17 KB │ 5.42 KB ║
-║ node │ 2.71 KB │ 1.81 KB ║
-║ opcode-compiler │ 29.72 KB │ 13.19 KB ║
-║ owner │ 159 B │ 202 B ║
-║ program │ 7.1 KB │ 3.62 KB ║
-║ reference │ 5.49 KB │ 3.21 KB ║
-║ runtime │ 94.98 KB │ 42.28 KB ║
-║ tracking │ 989 B │ 961 B ║
-║ util │ 3.03 KB │ 2.29 KB ║
-║ validator │ 15.63 KB │ 6.83 KB ║
-║ vm │ 784 B │ 798 B ║
-║ wire-format │ 1.84 KB │ 1.35 KB ║
-╚═════════════════╧═══════════╧══════════╝
+╔═════════════════╤══════════╤══════════╗
+║ @glimmer/* │ Min │ Gzip ║
+╟─────────────────┼──────────┼──────────╢
+║ Total │ 38.26 KB │ 21.76 KB ║
+╟─────────────────┼──────────┼──────────╢
+║ destroyable │ 2.78 KB │ 1.38 KB ║
+║ encoder │ 81 B │ 171 B ║
+║ env │ 0 B │ 0 B ║
+║ global-context │ 886 B │ 545 B ║
+║ manager │ 977 B │ 629 B ║
+║ node │ 175 B │ 266 B ║
+║ opcode-compiler │ 1.11 KB │ 949 B ║
+║ owner │ 159 B │ 202 B ║
+║ program │ 252 B │ 284 B ║
+║ reference │ 548 B │ 544 B ║
+║ runtime │ 10.32 KB │ 5.29 KB ║
+║ tracking │ 1.34 KB │ 1.18 KB ║
+║ util │ 1.85 KB │ 1.59 KB ║
+║ validator │ 15.53 KB │ 6.9 KB ║
+║ vm │ 495 B │ 569 B ║
+║ wire-format │ 1.84 KB │ 1.35 KB ║
+╚═════════════════╧══════════╧══════════╝
Details
|
Contributor
Author
|
This now has merged the history and unified the test suites.
|
…h doesn't work in prod builds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress on harmonizing the glimmer-vm repo with this repo so they can eventually merge.