Skip to content

feat(frontend): add responsive drawers, optimistic rollback, and chart test suites - #1681

Merged
emdevelopa merged 1 commit into
emdevelopa:mainfrom
CMI-James:feat-frontend-modals-and-chart-tests
Oct 21, 2026
Merged

emdevelopa merged 1 commit into
emdevelopa:mainfrom
CMI-James:feat-frontend-modals-and-chart-tests

Conversation

@CMI-James

Copy link
Copy Markdown
Contributor

Summary of Changes

This pull request resolves assigned issues #1667, #1663, #1662, and #1660:

  1. MerchantProfileDropdown Responsive Drawer & Touch Dismiss ([Frontend] Add responsive drawer view and touch gesture support to Merchant Profile Card #1667):

    • Added responsive fixed bottom drawer styling on mobile (max-h-[85vh], rounded top borders, mobile backdrop).
    • Added visual drawer drag handle indicator (data-testid="merchant-drawer-handle").
    • Implemented touch gesture tracking with swipe-down dismiss (>50px threshold).
    • Added comprehensive unit tests and updated component snapshots.
  2. AssetConverter Responsive Drawer View & Touch Gestures ([Frontend] Add responsive drawer view and touch gesture support to Asset Converter Modal #1662):

    • Added mobile-optimized bottom sheet drawer styling (data-testid="asset-converter-modal").
    • Added drawer drag handle indicator (data-testid="asset-converter-drawer-handle").
    • Added swipe-down gesture listener to dismiss converter modal.
  3. AssetConverter Optimistic Quote Updates & Horizon Network Rollback ([Frontend] Implement optimistic state rollback with toast feedback upon network failure in Asset Converter Modal #1663):

    • Implemented optimistic quote state updates while path payment query is in-flight.
    • Handled network errors / 404s by rolling back state to the previous quote and triggering error toast notifications via sonner.
    • Added full unit test suite with mock Horizon server interactions.
  4. ApiUsageChart Comprehensive Test Suite ([Frontend] Add comprehensive snapshot tests and user interaction test suite for API Usage Chart #1660):

    • Created frontend/src/components/ApiUsageChart.test.tsx covering:
      • Unauthenticated prompt when API key is missing.
      • Loading spinner state during data fetch.
      • Error banner on network rejection or HTTP failure.
      • Empty data state ("No API usage data available").
      • Total request count calculations and chart property assertions.
      • Responsive compact mode (mobile <=640px) vs desktop dimensions and tick formatting.
      • Multi-locale formatting support (e.g. Spanish formatting).
      • Component snapshot tests across all states.

Closes #1667
Closes #1663
Closes #1662
Closes #1660

@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown

@CMI-James is attempting to deploy a commit to the Emmanuel's projects Team on Vercel.

A member of the Team first needs to authorize it.

@emdevelopa
emdevelopa merged commit 9f7872b into emdevelopa:main Oct 21, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment