NXT-9086: Added a check to not externalize sub-dependencies of ignored packages#155
Open
daniel-stoian-lgp wants to merge 1 commit intodevelopfrom
Open
NXT-9086: Added a check to not externalize sub-dependencies of ignored packages#155daniel-stoian-lgp wants to merge 1 commit intodevelopfrom
daniel-stoian-lgp wants to merge 1 commit intodevelopfrom
Conversation
…red packages and bundle them directly into the view instead of trying to externalize them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
query-string package changes:
7.x Structure
8.x Structure
After updating query-string in ui-test-utils:
Before the Fix
What happened during build:
./base.js@enact/ui-test-utils/node_modules/query-string/baseResolution
Fixed
EnactFrameworkRefPluginto detect imports that come from ignored packages and bundle them directly into the view instead of trying to externalize them.After the Fix
What happens during build:
@enact/ui-test-utils)query-string(includingbase.js) directly into the view "/* harmony import / var base_js__WEBPACK_IMPORTED_MODULE_0_ = webpack_require(/! ./base.js */ "./node_modules/@enact/ui-test-utils/node_modules/query-string/base.js")"Additional Considerations
Links
NXT-9086
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian ([email protected])