Skip to content

chore: alter file/dir names to match eip/erc#1

Closed
JFrankfurt wants to merge 1 commit into
ensdomains:masterfrom
JFrankfurt:tweak-naming-convention
Closed

chore: alter file/dir names to match eip/erc#1
JFrankfurt wants to merge 1 commit into
ensdomains:masterfrom
JFrankfurt:tweak-naming-convention

Conversation

@JFrankfurt
Copy link
Copy Markdown

@JFrankfurt JFrankfurt commented Jul 19, 2024

Would be nice to match the existing pattern from similar repositories. (I've got a tool that assumes the same proposal structure as EIP/ERC/CAIP and I selfishly want the integration to just be me dropping in a new url.)

Would also be nice to tweak the repo name to ENSIPs

https://github.com/ethereum/ERCs/tree/master/ERCS

image

@JFrankfurt
Copy link
Copy Markdown
Author

heads up @lucemans

@JFrankfurt
Copy link
Copy Markdown
Author

I want to include ENSIPs here https://twitter.com/jordanfrankfurt/status/1815409274220323022

@lucemans
Copy link
Copy Markdown
Contributor

lucemans commented Sep 3, 2024

Interesting... ill work on making sure theyre in a standard format so that you should be able to parse them.
The current idea is that we will have

  • app - for rendering a browser preview (cf pages etc) (potentially a standalone deploy)
  • bot - for linting, styling, and rule-checking
  • ensips - for the actual ensips (numbered by 1.md, etc)

@lucemans
Copy link
Copy Markdown
Contributor

lucemans commented Sep 4, 2024

Update now that more development progress has occured!

ENSIPs can be found at /ensips/1.md.
For linking to an ENSIPs please link to https://docs.ens.domains/ensip/1

Submitting an ENSIP can be done via PR and under the /ensip/x path
CF Pages preview urls are available per PR as soon as CI checks pass!

Checkout the template here:
#4

@lucemans
Copy link
Copy Markdown
Contributor

lucemans commented Sep 4, 2024

With regards to updating your extension I fear it will be slightly more then just dropping in a url.
By the looks of it a git submodule, an addition here, and here, but I hope it works out in the end!

Let me know if there is anything from my side I can do to accomodate! Closing this issue for now!

@lucemans lucemans closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants