Add ENSjs v4, web3.py, Thirdweb v5, and Alloy resolution tests#3
Draft
Dhaiwat10 wants to merge 4 commits into
Draft
Add ENSjs v4, web3.py, Thirdweb v5, and Alloy resolution tests#3Dhaiwat10 wants to merge 4 commits into
Dhaiwat10 wants to merge 4 commits into
Conversation
Tests @ensdomains/ensjs v4.2.2 against all 9 resolution test cases. Results: 8/9 pass — all 4 ENSv2 readiness criteria met (Universal Resolver, CCIP-Read, DNS name detection, multichain coinType). Only failure is reverse-l2 (Base) which times out, likely due to the L2 reverse resolution service being down. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests web3.py v7.15.0 against all 9 resolution test cases. Results: 3/9 pass — not ENSv2-ready. Uses old Universal Resolver (returns 0x1111), CCIP-Read fails due to supportsInterface check blocking offchain resolvers, and L2 reverse resolution not supported. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dhaiwat10
changed the title
Tests thirdweb v5 against 7/9 resolution test cases (no coinType or contenthash API). Results: 3/7 pass — not ENSv2-ready. Uses old Universal Resolver (returns 0x1111), CCIP-Read OffchainLookup reverts not handled, and no coinType param for L2 address resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dhaiwat10
changed the title
Tests alloy-ens v1.8.3 against 6/9 resolution test cases (no coinType, contenthash, or L2 reverse API). Results: 2/6 pass — not ENSv2-ready. Uses old ENS Registry directly instead of Universal Resolver, no CCIP-Read support, and cannot resolve offchain or DNS names. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dhaiwat10
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ensdomains/ensjsv4.2.2 (packages/ensjs-v4/)web3.pyv7.15.0 (packages/web3py/)thirdwebv5 (packages/thirdweb-v5/)alloy-ensv1.8.3 (packages/alloy/)ENSjs v4 Results: 8/9 pass ✅
All 4 ENSv2 readiness criteria met.
universal-resolverforward-base-onchainforward-eth-offchainforward-text-onchainforward-text-offchainforward-contenthashforward-dns-offchainreverse-ethreverse-l2web3.py Results: 3/9 pass ❌
Not ENSv2-ready. Old Universal Resolver, CCIP-Read blocked by
supportsInterface.universal-resolver0x1111...(old resolver)forward-base-onchainforward-eth-offchainforward-text-onchainforward-text-offchainforward-contenthashforward-dns-offchainreverse-ethreverse-l2Thirdweb v5 Results: 3/7 tested ❌
Not ENSv2-ready. Old Universal Resolver, CCIP-Read not handled. No coinType or contenthash API.
universal-resolver0x1111...(old resolver)forward-base-onchainforward-eth-offchainforward-text-onchainforward-text-offchainforward-contenthashforward-dns-offchainreverse-ethreverse-l2resolveL2Nameon BaseAlloy (Rust) Results: 2/6 tested ❌
Not ENSv2-ready. Uses old ENS Registry directly, no Universal Resolver, no CCIP-Read, no coinType/contenthash/L2 reverse.
universal-resolver0x1111...(old registry path)forward-base-onchainforward-eth-offchainforward-text-onchainforward-text-offchainforward-contenthashforward-dns-offchainreverse-ethreverse-l2Test plan
bun install && bun testinpackages/ensjs-v4/pip install web3 pytest && pytest -vinpackages/web3py/THIRDWEB_SECRET_KEY=... bun testinpackages/thirdweb-v5/cargo testinpackages/alloy/reverse-l2for ensjs once Base reverse resolution service is back up