fix: missing separator in MinerEvaluationCache.get() log message#200
Open
njlazzar-su wants to merge 4 commits intoentrius:testfrom
Open
fix: missing separator in MinerEvaluationCache.get() log message#200njlazzar-su wants to merge 4 commits intoentrius:testfrom
njlazzar-su wants to merge 4 commits intoentrius:testfrom
Conversation
The log message in the cache miss branch uses Python implicit string concatenation but the last line is missing the f-string prefix and a separator. This causes the output to read: '...github_id=123)Removing cached evaluation' instead of: '...github_id=123). Removing cached evaluation' Add f-prefix and period+space separator.
Collaborator
|
needs to target test branch |
Contributor
Author
|
fixed |
anderdc
requested changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix malformed log message in
MinerEvaluationCache.get()when a cache identity mismatch occurs.Problem
The debug log message uses Python implicit string concatenation across multiple lines, but the last line is a plain string (not an f-string) and is missing a separator:
This produces output like:
Instead of:
Fix
f-string prefix to the last line