Skip to content

fix: escape file paths in GraphQL expressions to prevent query syntax errors #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njlazzar-su wants to merge 2 commits into
base: test
Choose a base branch
from
+11 −3
Open

fix: escape file paths in GraphQL expressions to prevent query syntax errors #201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
836c5c8
fix: escape file paths in GraphQL expression strings to prevent query…
nicklazzari Feb 17, 2026
1e3a230
Merge branch 'test' into fix/graphql-expression-injection
njlazzar-su Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions gittensor/utils/github_api_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,7 +846,10 @@ def fetch_file_contents_batch(
# Build GraphQL query with aliased file fields
file_fields = []
for i, path in enumerate(file_paths):
expression = f'{head_sha}:{path}'
# Escape backslashes and double quotes in file paths to prevent
# GraphQL query syntax errors from special characters in filenames
safe_path = path.replace('\\', '\\\\').replace('"', '\\"')
expression = f'{head_sha}:{safe_path}'
file_fields.append(
f'file{i}: object(expression: "{expression}") {{ ... on Blob {{ text byteSize isBinary }} }}'
)
Expand Down Expand Up @@ -932,16 +935,21 @@ def fetch_file_contents_with_base(
base_path = fc.previous_filename if fc.previous_filename else fc.filename
head_path = fc.filename

# Escape backslashes and double quotes in file paths to prevent
# GraphQL query syntax errors from special characters in filenames
safe_base_path = base_path.replace('\\', '\\\\').replace('"', '\\"')
safe_head_path = head_path.replace('\\', '\\\\').replace('"', '\\"')

# Only fetch base version if file wasn't newly added
if fc.status != 'added':
base_expr = f'{base_sha}:{base_path}'
base_expr = f'{base_sha}:{safe_base_path}'
file_fields.append(
f'base{i}: object(expression: "{base_expr}") {{ ... on Blob {{ text byteSize isBinary }} }}'
)

# Only fetch head version if file wasn't deleted
if fc.status != 'removed':
head_expr = f'{head_sha}:{head_path}'
head_expr = f'{head_sha}:{safe_head_path}'
file_fields.append(
f'head{i}: object(expression: "{head_expr}") {{ ... on Blob {{ text byteSize isBinary }} }}'
)
Expand Down