Bump serde_jcs#27
Merged
Merged
Conversation
serde_jcs 0.1.0's `Formatter::write_number_str` is a `todo!()` that panics
("not yet implemented: Handle number str (u128/i128)") whenever a JSON value
containing a number is JCS-canonicalized while serde_json's `arbitrary_precision`
feature is active in the build. Since the VC 2.0 migration (ssi 0.16) that
feature is force-enabled build-wide via did-ethr -> serde_json/arbitrary_precision
and Cargo feature unification, so every `serde_jcs::to_string` over number-bearing
JSON now panics -- breaking `cid compute --canonicalize json-jcs` and VC issuance
in the integrity-monorepo fixtures.
Upstream serde_jcs 0.2.0 implements write_number_str / write_i128 / write_u128,
fixing the panic. Canonical output is byte-identical for inputs 0.1.0 could
already serialize (both format numbers via ryu-js per the JCS ECMAScript number
grammar), so existing CIDs are unaffected; 0.2.0 only adds the number paths
0.1.0 left as `todo!()`.
Bump the pin in the two crates that compute JCS CIDs (integrity-cid and
integrity-lineage-models). ssi-jwk still pins ^0.1.0, so serde_jcs 0.1.0 remains
in the tree for it (JWK thumbprints, no numeric fields -> never hits the todo).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cameronfyfe
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created to fix https://github.com/eqtylab/integrity-monorepo/issues/1653
After this is merged and tagged, I can merge a similar PR to integrity-monorepo.
At least one of the errors from that issue is because ssi 0.16 upgrade brought in serde_jcs, but the old version panics on numbers.