Integrate unresolved ARTS2D resonances into detector bins - #143
Merged
Conversation
Member
Author
|
Manual validation on current head 3cc7296 is green: both Linux CPU and project GPU jobs completed the full suite (186 passed, 5 skipped). Run: https://github.com/ergodicio/tsadar/actions/runs/33329223046 This was dispatched manually because the workflow only auto-triggers for PRs based on main, while #143 is intentionally stacked on #142. The first dispatch exposed a test-only GPU allocation problem from using reverse-mode Jacobians for one scalar input and hundreds of outputs; the regression now uses forward mode for the full detector Jacobian and independently checks a scalar reverse-mode loss gradient. |
joglekara
force-pushed
the
codex/issue-134-unresolved-resonance
branch
from
August 30, 2026 21:07
3cc7296 to
6917ec4
Compare
joglekara
changed the base branch from
codex/issue-135-arts2d-susceptibility
to
main
August 30, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #142 (merged). Fixes #134.
What changed
Re(epsilon)on a fine fixed scan, differentiates roots implicitly, and tan-maps disjoint coarse-panel neighborhoods through the local complex-linearized resonance.root_scan_panels(4096) fromintegration_panels(256), raises static root capacity to 16, and returns fatal fixed-shape diagnostics instead of partial results.iawfilterattenuation to the continuous source spectrum with exact integration breakpoints;iawoffremains a detector-space visualization mask.Direct quadrature versus local correction
On the corrected 22-degree Maxwellian benchmark, the unresolved root is at 474.199678891 nm with 3.49399e-4 nm HWHM. The adaptive detector-area reference is 0.6525638697.
The local method gives no forward speedup and its faster backward pass is numerically wrong, so it is recorded as a rejected benchmark rather than exposed to fitting.
Root-scan and convergence evidence
The representative 449-670 nm spectrum has eight roots, including a pair only 0.096012 nm apart. Across 39 scan phases, 2048 panels missed that pair in six phases; 4096 and 8192 found all eight every time. Warm one-geometry scan timing was 23.5/32.2/55.8 ms, so 4096 is the smallest tested phase-stable default.
For the physical narrow-line regression, 64-to-128 and 64-to-256 integration refinement changed detector values by at most 4.94e-5 and gradients by at most 2.64e-4. Fine-grid phase variation was 2.10e-6 for values and 2.06e-5 for gradients, well below the 1% target.
Validation
186 passed, 5 skippedon both Linux CPU and project GPU for rebased head6917ec4d: https://github.com/ergodicio/tsadar/actions/runs/33335580949