-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
add variant PZEM-004T-100A-D-P(V1.0) #5737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughDocumentation updates for PZEM sensors: warning in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/components/sensor/pzemac.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
- Do not generate or add any sequence diagrams
Files:
content/components/sensor/pzemac.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: jesserockz
Repo: esphome/esphome-docs PR: 4865
File: .github/workflows/needs-docs.yml:0-0
Timestamp: 2025-05-01T03:29:47.922Z
Learning: In the esphome-docs repository, the "current" label is automatically added by a bot to pull requests, making it a reliable indicator for the target branch.
🪛 LanguageTool
content/components/sensor/pzemac.md
[grammar] ~161-~161: Ensure spelling is correct
Context: ...using {{< docref "pzem004t/" >}}. - One noteable difference to other boards is the 5 pin...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~161-~161: Use a hyphen to join words.
Context: ...able difference to other boards is the 5 pin connection labeled 5V, RX, TX,...
(QB_NEW_EN_HYPHEN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (3)
content/components/sensor/pzemac.md (3)
154-157: Section structure and organization look good.The new "Other Devices" subsection is well-positioned and the naming clearly identifies the specific variant being documented.
160-163: Content effectively addresses the PR objective.The documentation clearly explains the distinguishing features of the PZEM-004T-100A-D-P(V1.0) variant, specifically calling out the silkscreen marking confusion and providing practical technical details (pinout, voltage compatibility). This should help users select the correct variant and connection method.
158-158: The review comment references incorrect content. Line 158 of pzemac.md contains- {{< docref "pzemdc/" >}}, not an image reference. The actual image reference in the file is on line 27 and correctly usespzem-ac.png, which exists in the repository. The filenamepzem-004t-100a-d-p-v1.0.jpgdoes not exist anywhere in the repository and does not appear in this file.Likely an incorrect or invalid review comment.
Description:
I spent some time today trying to use the wrong module for a board marked PZEM-004T-100A-D-P(V1.0).
Hope this is helpful for others.
Checklist:
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.