fix(board_manager): default disabled PA pin to -1 instead of GPIO0 (AUD-7247) - #43
Open
wxzed wants to merge 1 commit into
Open
fix(board_manager): default disabled PA pin to -1 instead of GPIO0 (AUD-7247)#43wxzed wants to merge 1 commit into
wxzed wants to merge 1 commit into
Conversation
Contributor
|
Processing this fix. The issue will be fixed in v0.5.10. |
Contributor
|
This fix has now been included in v0.5.10. Thanks again for the contribution and testing! Also, esp_board_manager now has a standalone repository. Feel free to report future issues or submit PRs there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the default
pa_cfginitialization indev_audio_codec.pywhen no PA peripheral is configured.Problem
When an
audio_codecdevice does not definegpio_pa_control,_parse_codec_peripherals()initializes:pa_cfg.name = NULLpa_cfg.port = 0On ESP32-class targets, GPIO0 is a valid GPIO number, so
0is ambiguous with “PA disabled” and can conflict with boards that use GPIO0 as I2S BCLK (see discussion in issue #42).Change (this PR)
pa_cfg.portfrom0to-1when PA is not configured.Out of scope (tracked separately / follow-up)
dev_audio_codec.c(only applypa_pinwhen PA is explicitly configured) is suggested in Bug: dev_audio_codec generator defaults PA pin to GPIO0 when PA not configured (AUD-7246) #42 but not included in this PR to keep the change minimal.Related
Fixes #42
Testing
idf.py gen-bmgr-configfor a board whereaudio_codechas nogpio_pa_control.gen_board_device_config.cshowspa_cfg.port = -1when PA is absent.Checklist