Skip to content

fix: fix addr8v8 read err in sccb_ng #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WangYuxin-esp wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −5
Open

fix: fix addr8v8 read err in sccb_ng #828

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions driver/sccb-ng.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,17 +225,22 @@ uint8_t SCCB_Read(uint8_t slv_addr, uint8_t reg)
i2c_master_dev_handle_t dev_handle = *(get_handle_from_address(slv_addr));

uint8_t tx_buffer[1];
uint8_t rx_buffer[1];
uint8_t rx_buffer[1] = {0};

tx_buffer[0] = reg;

esp_err_t ret = i2c_master_transmit_receive(dev_handle, tx_buffer, 1, rx_buffer, 1, TIMEOUT_MS);
esp_err_t ret = i2c_master_transmit(dev_handle, tx_buffer, 1, TIMEOUT_MS);

if (ret != ESP_OK)
{
ESP_LOGE(TAG, "SCCB_Read Failed addr:0x%02x, reg:0x%02x, data:0x%02x, ret:%d", slv_addr, reg, rx_buffer[0], ret);
if (ret != ESP_OK) {
ESP_LOGE(TAG, "SCCB_Read addr phase failed addr:0x%02x, reg:0x%02x, ret:%d", slv_addr, reg, ret);
return 0;
}

ret = i2c_master_receive(dev_handle, rx_buffer, 1, TIMEOUT_MS);
if (ret != ESP_OK) {
ESP_LOGE(TAG, "SCCB_Read Failed addr:0x%02x, reg:0x%02x, ret:%d", slv_addr, reg, ret);
}
ESP_LOGW(TAG, "read OK");
return rx_buffer[0];
}

Expand Down
Loading